-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Alpha fixes and improvements #1319
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Any tests we can add/extend to verify stack traces don't get lost?
Codecov Report
@@ Coverage Diff @@
## main #1319 +/- ##
=======================================
Coverage 83.37% 83.37%
=======================================
Files 264 268 +4
Lines 6333 6335 +2
Branches 1001 1001
=======================================
+ Hits 5280 5282 +2
Misses 844 844
Partials 209 209
Flags with carried forward coverage won't be shown. Click here to find out more.
|
@@ -37,6 +39,7 @@ internal sealed class HedgingResilienceStrategy<T> : ResilienceStrategy | |||
|
|||
public EventInvoker<OnHedgingArguments>? OnHedging { get; } | |||
|
|||
[ExcludeFromCodeCoverage] // coverlet issue |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a specific issue we could link to?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This one for example;
coverlet-coverage/coverlet#1284
There are more of those related to await handling
Details on the issue fix or feature implementation
Fixes and improvements based on some testing and playing with the alpha1 package.
CancellationTokenSource
too lateResultFormatter
not being used for resilience events.<Strategy>PredicateArguments
pattern. The delegate's name is alwaysShouldHandle
.ShouldHandle
callback for fallback.Contributes to #1301
Confirm the following