Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow implicit conversion of PredicateBuilder to delegates #1332

Merged
merged 3 commits into from
Jun 21, 2023

Conversation

martintmk
Copy link
Contributor

@martintmk martintmk commented Jun 21, 2023

Details on the issue fix or feature implementation

Contributes to #1329

Confirm the following

  • I started this PR by branching from the head of the default branch
  • I have targeted the PR to merge into the default branch
  • I have included unit tests for the issue/feature
  • I have successfully run a local build

@martintmk martintmk added the v8 Issues related to the new version 8 of the Polly library. label Jun 21, 2023
@martintmk martintmk added this to the v8.0.0 milestone Jun 21, 2023
@martintmk martintmk force-pushed the mtomka/predicatebuilder branch from bd696f3 to 901def1 Compare June 21, 2023 07:35
@codecov
Copy link

codecov bot commented Jun 21, 2023

Codecov Report

Merging #1332 (6faa97d) into main (73422d5) will decrease coverage by 0.05%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #1332      +/-   ##
==========================================
- Coverage   83.53%   83.49%   -0.05%     
==========================================
  Files         269      270       +1     
  Lines        6397     6379      -18     
  Branches     1003     1003              
==========================================
- Hits         5344     5326      -18     
  Misses        844      844              
  Partials      209      209              
Flag Coverage Δ
linux 83.49% <100.00%> (?)
macos 83.49% <100.00%> (-0.05%) ⬇️
windows 83.49% <100.00%> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ack/FallbackResilienceStrategyBuilderExtensions.cs 100.00% <ø> (ø)
.../Retry/RetryResilienceStrategyBuilderExtensions.cs 100.00% <ø> (ø)
src/Polly.Core/PredicateBuilder.Operators.cs 100.00% <100.00%> (ø)
src/Polly.Core/PredicateBuilder.TResult.cs 100.00% <100.00%> (ø)

@martintmk martintmk merged commit 12b66c2 into main Jun 21, 2023
@martintmk martintmk deleted the mtomka/predicatebuilder branch June 21, 2023 12:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
v8 Issues related to the new version 8 of the Polly library.
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants