Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix logging of execution attempt #1341

Merged
merged 2 commits into from
Jun 22, 2023
Merged

Conversation

martintmk
Copy link
Contributor

@martintmk martintmk commented Jun 22, 2023

Details on the issue fix or feature implementation

While testing the alpha.2 I have noticed that execution attempt is being logged with warning level. This PR adds separate logging entry for execution attempt and changes the log level based on whether the result was handled or not.

Confirm the following

  • I started this PR by branching from the head of the default branch
  • I have targeted the PR to merge into the default branch
  • I have included unit tests for the issue/feature
  • I have successfully run a local build

@martintmk martintmk added the v8 Issues related to the new version 8 of the Polly library. label Jun 22, 2023
@martintmk martintmk added this to the v8.0.0 milestone Jun 22, 2023
@martintmk martintmk enabled auto-merge (squash) June 22, 2023 11:54
@codecov
Copy link

codecov bot commented Jun 22, 2023

Codecov Report

Merging #1341 (55a5700) into main (18171df) will increase coverage by 0.03%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #1341      +/-   ##
==========================================
+ Coverage   83.54%   83.58%   +0.03%     
==========================================
  Files         270      270              
  Lines        6374     6389      +15     
  Branches     1003     1008       +5     
==========================================
+ Hits         5325     5340      +15     
  Misses        840      840              
  Partials      209      209              
Flag Coverage Δ
linux ?
macos 83.58% <100.00%> (+0.03%) ⬆️
windows 83.58% <100.00%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...s/Telemetry/ResilienceTelemetryDiagnosticSource.cs 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

@martintmk martintmk merged commit 5488560 into main Jun 22, 2023
@martintmk martintmk deleted the mtomka/fix-execution-attempt-logging branch June 22, 2023 12:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
v8 Issues related to the new version 8 of the Polly library.
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants