Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop TelemetryResilienceStrategy #1482

Merged
merged 11 commits into from
Aug 11, 2023

Conversation

martintmk
Copy link
Contributor

@martintmk martintmk commented Aug 11, 2023

Details on the issue fix or feature implementation

In this PR we are dropping the internal TelemetryResilienceStrategy that was used to track pipeline executions. Instead, these are now tracked the standard way using the arguments emitted from Polly.Core.

Additionally, this allowed us to drop CompositeStrategyBuilderBase.OnCreatingStrategy and simplify telemetry story.

Confirm the following

  • I started this PR by branching from the head of the default branch
  • I have targeted the PR to merge into the default branch
  • I have included unit tests for the issue/feature
  • I have successfully run a local build

@martintmk martintmk added the v8 Issues related to the new version 8 of the Polly library. label Aug 11, 2023
@martintmk martintmk added this to the v8.0.0 milestone Aug 11, 2023
@martintmk martintmk changed the title Drop TelemetryResilienceStrategy and Drop TelemetryResilienceStrategy Aug 11, 2023
@codecov
Copy link

codecov bot commented Aug 11, 2023

Codecov Report

Merging #1482 (f87ddce) into main (3663510) will decrease coverage by 0.05%.
Report is 5 commits behind head on main.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #1482      +/-   ##
==========================================
- Coverage   83.92%   83.88%   -0.05%     
==========================================
  Files         276      278       +2     
  Lines        6508     6491      -17     
  Branches     1016     1014       -2     
==========================================
- Hits         5462     5445      -17     
  Misses        837      837              
  Partials      209      209              
Flag Coverage Δ
linux ?
macos 83.88% <100.00%> (-0.05%) ⬇️
windows 83.88% <100.00%> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
src/Polly.Core/Telemetry/TelemetryUtil.cs 100.00% <ø> (ø)
...try/TelemetryCompositeStrategyBuilderExtensions.cs 100.00% <ø> (ø)
src/Polly.Core/CompositeStrategyBuilderBase.cs 100.00% <100.00%> (ø)
...rc/Polly.Core/Hedging/HedgingResilienceStrategy.cs 100.00% <100.00%> (ø)
src/Polly.Core/Hedging/OnHedgingArguments.cs 100.00% <100.00%> (ø)
...y.Core/Telemetry/ExecutionAttemptArguments.Pool.cs 100.00% <100.00%> (ø)
.../Polly.Core/Telemetry/ExecutionAttemptArguments.cs 100.00% <100.00%> (ø)
...y.Core/Telemetry/PipelineExecutedArguments.Pool.cs 100.00% <100.00%> (ø)
.../Polly.Core/Telemetry/PipelineExecutedArguments.cs 100.00% <100.00%> (ø)
...Polly.Core/Telemetry/PipelineExecutingArguments.cs 100.00% <100.00%> (ø)
... and 5 more

@martintmk martintmk enabled auto-merge (squash) August 11, 2023 08:05
@martintmk martintmk merged commit fc58ddc into main Aug 11, 2023
@martintmk martintmk deleted the mtomka/drop-TelemetryResilienceStrategy branch August 11, 2023 08:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
v8 Issues related to the new version 8 of the Polly library.
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants