-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Drop TelemetryResilienceStrategy
#1482
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martincostello
approved these changes
Aug 11, 2023
src/Polly.Extensions/Telemetry/ResilienceTelemetryDiagnosticSource.cs
Outdated
Show resolved
Hide resolved
martintmk
changed the title
Drop
Drop Aug 11, 2023
TelemetryResilienceStrategy
and TelemetryResilienceStrategy
Codecov Report
@@ Coverage Diff @@
## main #1482 +/- ##
==========================================
- Coverage 83.92% 83.88% -0.05%
==========================================
Files 276 278 +2
Lines 6508 6491 -17
Branches 1016 1014 -2
==========================================
- Hits 5462 5445 -17
Misses 837 837
Partials 209 209
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details on the issue fix or feature implementation
In this PR we are dropping the internal
TelemetryResilienceStrategy
that was used to track pipeline executions. Instead, these are now tracked the standard way using the arguments emitted fromPolly.Core
.Additionally, this allowed us to drop
CompositeStrategyBuilderBase.OnCreatingStrategy
and simplify telemetry story.Confirm the following