-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cleanup the Polly.Core README.md #1539
Conversation
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## main #1539 +/- ##
==========================================
- Coverage 83.93% 83.92% -0.02%
==========================================
Files 279 279
Lines 6523 6518 -5
Branches 1017 1017
==========================================
- Hits 5475 5470 -5
Misses 839 839
Partials 209 209
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
I mentioned it somewhere before previously, but I think this is a good opportunity to introduce MarkdownSnippets for the documentation. This will allow us to define the snippets in code we can compile against, refactor etc. to ensure they still work, and then have them automatically copied over into the README files. |
Love this idea, do you think you can give the infra a shot? Then in follow-up I can do some cleanup. |
I haven't used it for a while (and you're writing the snippets here already anyway 😄), but it's used in this repo where I set it up a while ago you should be able to copy the things needed from: https://github.com/justeattakeaway/httpclient-interception |
Let me do this in follow-up. |
Details on the issue fix or feature implementation
Contributes to #1091
Confirm the following