.NET 8 preparation #1734
Merged
.NET 8 preparation #1734
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add Visual Studio spell checker dictionary.
Put the mutation report into the artifacts directory.
Tidy up the docfx .gitignore files.
Fix typo
- Remove some redundant code analysis suppressions. - Resolve some new code analysis warnings from .NET 8 SDK. - Fix-up some whitespace. - Fix a minor typo.
Fix xunit warning about duplicated test cases by using a `Func<TimeSpan>` so we can use `Timeout.InfiniteTimeSpan` and `TimeSpan.FromMilliseconds(-1)` which are equal.
Avoid warnings from enabling trim analysis for unsupported TFMs when using the .NET 8 SDK.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1734 +/- ##
=======================================
Coverage 84.56% 84.56%
=======================================
Files 307 307
Lines 6790 6790
Branches 1043 1043
=======================================
Hits 5742 5742
Misses 839 839
Partials 209 209
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
Attempt to resolve mutant in the ResiliencePipeline constructor.
Use attributes instead of pragmas so the native AOT compiler can see them. Relates to App-vNext#1732.
|
@martintmk Can you help me resolve the mutant? I tried fixing it in 4723fdc but that just seemed to make it worse 😅 |
Allow for missing mutation to unblock the PR. Can cycle back to raise it back to 100 later when I work out how to appease the tool.
Fix Stryker configuration to properly allow for some slack.
This was referenced Oct 27, 2023
Closed
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-pick various changes from #1144 that do not need the .NET 8 SDK to actually be used yet.
Func<TimeSpan>so we can useTimeout.InfiniteTimeSpanandTimeSpan.FromMilliseconds(-1)which are equal.