-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Simmy API review Part 3 - Set enabled to true by default #1916
Simmy API review Part 3 - Set enabled to true by default #1916
Conversation
@martintmk Shall I add the renaming of |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1916 +/- ##
==========================================
- Coverage 84.80% 84.79% -0.01%
==========================================
Files 312 312
Lines 6897 6893 -4
Branches 1056 1056
==========================================
- Hits 5849 5845 -4
Misses 839 839
Partials 209 209
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is much terser and intuitive.
I wonder if we should put a note in the documentation somewhere that people should take care with the default being on, as if this is being used in production you'd be getting chaos as an opt-out rather than an opt-in as a change in behaviour to previous releases(?) of Simmy, so any configuration that might be tied to turning chaos on or not would be inverted.
Done |
Co-authored-by: Martin Costello <[email protected]>
Pull Request
The issue or feature being addressed
#1901
Details on the issue fix or feature implementation
Enabled
fromfalse
totrue
Confirm the following