Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Performance: Use null for unused policy callbacks #742

Merged
merged 8 commits into from
Dec 30, 2019
Merged

Performance: Use null for unused policy callbacks #742

merged 8 commits into from
Dec 30, 2019

Conversation

reisenberger
Copy link
Member

The issue or feature being addressed

Implements #741 Handle non-configured policy callbacks as null (reduce allocations)

Details on the issue fix or feature implementation

  • Amends all policy configuration syntax to handle non-configured policy callbacks as null
  • Amends policy implementations to handle this

Confirm the following

  • I started this PR by branching from the head of the relevant vX.Y branch, or I have rebased on the relevant vX.Y branch, or I have merged the latest changes from the vX.Y branch
  • I have targeted the PR to merge into the latest dev vX.Y branch as the base branch
  • I have included unit tests for the issue/feature
  • I have successfully run a local build

@reisenberger reisenberger added this to the v8.0.0 milestone Dec 30, 2019
@reisenberger reisenberger merged commit 989c399 into App-vNext:v800 Dec 30, 2019
@reisenberger reisenberger mentioned this pull request Dec 30, 2019
Closed
@reisenberger reisenberger mentioned this pull request Jan 25, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
performance
Projects
None yet
Milestone
v8.0.0
Development

Successfully merging this pull request may close these issues.
1 participant
@reisenberger