Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

⬆️ Upgrade image dependency #243

Merged
merged 5 commits into from
Feb 13, 2023
Merged

⬆️ Upgrade image dependency #243

merged 5 commits into from
Feb 13, 2023

Conversation

apalala-dev
Copy link
Contributor

@apalala-dev apalala-dev commented Feb 6, 2023

Description

Upgrade image dependency to resolve conflicts with other packages.

Fixes #238.

Checklist

Before creating any Pull Request, confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]).

  • 📕 I read the Contributing page.
  • 🤝 I match the actual coding style.
  • ✅ I ran flutter analyze without any issues.

Breaking Change

  • 🛠 My feature contain breaking change.

Packages that rely on image 3.x will have compatibility issues with CamerAwesome.
However, since we have compatibility issues because other packages already rely on image 4.x, it's worth the upgrade.

@apalala-dev
Copy link
Contributor Author

Note: this PR can't be merged since it depends on a git dependency for photofilters.
Photofilters will have to be upgraded first.

@talamaska
Copy link

Are you sure this is enough?
I'm having all sort of issues when trying to override the dependencies with the ones you suggested and image package 4.0.x

camerawesome-1.2.1/lib/src/orchestrator/states/photo_camera_state.dart:153:44: Error: Too many positional arguments: 0 allowed, but 3 found.
image-4.0.13/lib/src/image/image.dart:198:3: Context: Found this candidate, but the arguments don't match.
camerawesome-1.2.1/lib/src/orchestrator/states/photo_camera_state.dart:159:56: Error: The argument type 'Image' can't be assigned to the parameter type 'String'.
camerawesome-1.2.1/lib/src/orchestrator/states/photo_camera_state.dart:159:67: Error: The argument type 'String' can't be assigned to the parameter type 'Image'.

@g-apparence
Copy link
Collaborator

Yes, my bad.
I've discussed that with the team and we are using a package to create the filters.
It's currently using version 3.x of images and the author is not answering to our PR.
We are working to remove this dependency.

@g-apparence g-apparence merged commit 7cc07b9 into master Feb 13, 2023
@talamaska
Copy link

FYI I think it is working. i haven't tested filters, but the rest is compiling and looks like working fine.

@istornz istornz deleted the update_image_dep branch March 27, 2023 08:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Outdated image package version dependency
3 participants