feat(HW2) #16
Open
feat(HW2) #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gimlocal
reviewed
Nov 7, 2024
| private void Start() | ||
| { | ||
| player = GameObject.Find("Player").transform; | ||
| } | ||
|
|
||
| void Update() | ||
| { |
| enemyObject.GetComponent<SpriteRenderer>().color = PickRandomColor(); | ||
| GameObject enemy = Instantiate(enemyPrefab, PickRandomPosition(), Quaternion.identity); | ||
| enemy.transform.SetParent(transform); // ������ ���� �θ� ������Ʈ�� �߰� | ||
| enemy.GetComponent<SpriteRenderer>().color = PickRandomColor(); |
|
|
||
| private Rigidbody2D rb; | ||
|
|
||
| [SerializeField] private float moveSpeed; |
There was a problem hiding this comment.
다른 의도가 있었는지는 모르겠는데, [SerializeField]는 기본적으로 private속성을 가지고 있기 때문에 뒤에 private를 안 달아도 됩니다.
| } | ||
|
|
||
| private void Move() | ||
| { |
There was a problem hiding this comment.
Update의 xInput과 yInput 변수들을 Move함수 내에서 정의하는게 더 깔끔할거 같네요.
|
|
||
| // Ÿ�� �������� �̵� | ||
| Vector3 direction = (target.position - transform.position).normalized; | ||
| transform.position += direction * speed * Time.deltaTime; |
There was a problem hiding this comment.
타겟이 없으면 화살삭제, 타겟 방향으로 이동
위 코드들도 다 함수로 만들어서 Update에 넣으면 좀더 깔끔한 코드가 될거 같네요
| } | ||
| } | ||
|
|
||
| return closestEnemy; |
|
코멘트 확인 수정 하고 코멘트 달아주시면 merge하겠습니다~ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
변경점 👍
새로 구현한 기능 및 주요 변경점
단검 공격 구현
버그 해결 💊
해결한 버그
리팩토링 🛠
리팩토링 내역
스크린샷 🖼
변경된 부분에 대한 스크린샷
비고 ✏
리뷰어에게 전하는 말 등
사용하지 않은 항목은 모두 지워주세요.