xml: make error struct constant #880
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As of https://gitlab.gnome.org/GNOME/libxml2/-/commit/61034116d0a3c8b295c6137956adc3ae55720711, the error struct in the callback is const
|
Thanks. |
EmmanuelP
pushed a commit
that referenced
this pull request
Mar 12, 2024
#880 introduced compatibility with libxml 2.12, but also caused compilation errors on systems with only 2.11. This fixes compilation for systems with older libxml versions.
EmmanuelP
pushed a commit
that referenced
this pull request
Mar 12, 2024
#880 introduced compatibility with libxml 2.12, but also caused compilation errors on systems with only 2.11. This fixes compilation for systems with older libxml versions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As of https://gitlab.gnome.org/GNOME/libxml2/-/commit/61034116d0a3c8b295c6137956adc3ae55720711, the error struct in the callback is const
I could also add a cast to
xmlStructuredErrorFuncon the use sites so it compiles against both new and old versions of libxml without warnings/errors.