-
-
Notifications
You must be signed in to change notification settings - Fork 346
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add timeout for auto packet size determination. #888
Conversation
Previously, we relied on the availability of the `GevSCPSFireTestPacket` feature. By adding a timeout we can now also support cameras without this feature.
@@ -726,6 +723,11 @@ auto_packet_size (ArvGvDevice *gv_device, gboolean exit_early, GError **error) | |||
guint current_size = packet_size; | |||
|
|||
do { | |||
if (g_timer_elapsed (timer, NULL) > 1.0) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was not sure whether we want:
- to make this value configurable or change it to another value.
- to change the APIs of
arv_gv_device_auto_packet_size
/arv_camera_gv_auto_packet_size
for this or - to introduce new methods, e.g.
arv_gv_device_auto_packet_size_timeout
/arv_camera_gv_auto_packet_size_timeout
@EmmanuelP Do you have any thoughts on this PR? Looking forward to hearing from you. |
@feuerste Hi. I'm running out of time lately. I'll try to get back to aravis before the end of this week. |
I don't know if the test packet is a mandatory feature of GigEVision. If I recall correctly, I have added the That means devices not supporting test packets will have an additional 1 second startup delay. I would prefer the addition of an
|
Thanks Emmanuel for your answer and thoughts. If there are cameras out in the wild which don't support test packets at all then I would rather like to keep it the way it is now and close this PR. Thanks again! |
Previously, we relied on the availability of the
GevSCPSFireTestPacket
feature. By adding a timeout we can now also support cameras without this feature.This is a follow-up to #886 and, as mentioned in e30bdaf, should also be able to deal with cameras such as the DMK 23G618 which takes 300ms to complete a single fire test packet command using
ArvGevSCPSFireTestPacket
.