Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SPDX license identifier #985

Merged
merged 1 commit into from
Feb 14, 2025
Merged

Add SPDX license identifier #985

merged 1 commit into from
Feb 14, 2025

Conversation

EmmanuelP
Copy link
Contributor

Fix #984

@EmmanuelP EmmanuelP marked this pull request as ready for review February 14, 2025 21:05
@EmmanuelP EmmanuelP merged commit d3495de into main Feb 14, 2025
5 checks passed
@EmmanuelP EmmanuelP deleted the wip/spdx branch February 14, 2025 21:05
@@ -1,14 +1,13 @@
GNU LESSER GENERAL PUBLIC LICENSE
Version 2.1, February 1999
GNU LIBRARY GENERAL PUBLIC LICENSE
Copy link

@rursprung rursprung Feb 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@EmmanuelP: you now changed some of this from "lesser" to "library" and others from "library" to "lesser". was it intentional to mix the two?

note: a previous version of my comment stated that they are not the same, but i just realised that LGPL-2.0 is "library" while LGPL-2.1 & newer are "lesser". so it might be intentional to have newer sources under 2.1? though then the SPDX header & copyright text disagree (since you wrote LGPL-2.0-or-newer everywhere but sometimes have the 2.1-or-newer copyright notice)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, I did not pay attention to the library to lesser change, until I have modified almost 300 files. I don't think it matters that much, but I will probably switch everything to the 2.1 version, the lesser one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

license mismatch (LGPL 2.1 vs 2.0)
2 participants