Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Performance: remove call to ResultInternal.wrap() #1576

Closed
lvca opened this issue Apr 29, 2024 · 1 comment
Closed

Performance: remove call to ResultInternal.wrap() #1576

lvca opened this issue Apr 29, 2024 · 1 comment
Assignees
@lvca
Labels
performance
Milestone
24.5.1

Comments

@lvca
Copy link
Contributor

lvca commented Apr 29, 2024 •
edited
Loading

From PR: #1568, originally discovered by @gramian as a hotspot executing a sql script.
@lvca lvca added this to the 24.5.1 milestone Apr 29, 2024
@lvca lvca self-assigned this Apr 29, 2024
@lvca lvca mentioned this issue Apr 29, 2024
Closed
2 tasks
lvca added a commit that referenced this issue Apr 29, 2024
@lvca
perf: removed call to ResultInternal.wrap()
e8c89bf 
Issue #1576
@lvca
Copy link
Contributor Author

lvca commented Apr 29, 2024

I left ResultInternal.wrap() as a public static method to allow legacy codebase to still use it with an explicit call.

@lvca lvca closed this as completed Apr 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lvca lvca

Labels
performance
Projects
None yet
Milestone
24.5.1
Development

No branches or pull requests
1 participant
@lvca