Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unexpected behavior of NULL_STRATEGY.SKIP indexing null values #567

Closed
erickj opened this issue Oct 16, 2022 · 2 comments
Closed

unexpected behavior of NULL_STRATEGY.SKIP indexing null values #567

erickj opened this issue Oct 16, 2022 · 2 comments
Assignees
Labels
bug Something isn't working
Milestone

Comments

@erickj
Copy link
Contributor

erickj commented Oct 16, 2022

ArcadeDB Version: 22.9.1

JDK Version: openjdk 11

OS: Linux jupiter 5.19.9-200.fc36.x86_64 #1 SMP PREEMPT_DYNAMIC Thu Sep 15 09:49:52 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux

Expected behavior

Null property values not to be indexed when defining the index with NULL_STRATEGY.SKIP

Actual behavior

the first document in the index with a null property value gets indexed, then future document insertions with a null property value fail with DuplicatedKeyException. see stacktrace in the gist

Steps to reproduce

see https://gist.github.com/erickj/d982096c5eee4f0f5311d16cdb56b525

If this is just my own misunderstanding of the NULL_STRATEGY.SKIP behavior I'm happy to update the documentation with the expected behavior. Otherwise I'm happy to work on a PR,

@lvca lvca added the bug Something isn't working label Oct 17, 2022
@lvca lvca self-assigned this Oct 17, 2022
@lvca lvca added this to the 22.10.1 milestone Oct 17, 2022
@lvca
Copy link
Contributor

lvca commented Oct 17, 2022

Reproduced, thanks for the test case.

lvca added a commit that referenced this issue Oct 17, 2022
@lvca
Copy link
Contributor

lvca commented Oct 17, 2022

The issue relies on a check that is not necessary in the case the value is NULL and the NULL STRATEGY is SKIP. This should also speed up operation for this specific use case. Fixed in the main branch and will be released with this month's version (22.10.1)

@lvca lvca closed this as completed Oct 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants