feat: Enhance RemoteServer and Console create-user to assign group
#1405
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robfrank
reviewed
Dec 28, 2023
| @@ -467,16 +467,25 @@ private void executeCreateUser(final String params) { | |||
| checkHasSpaces("User name", userName); | |||
|
|
|||
| final String password; | |||
| final List<String> databases; | |||
| HashMap<String,String> databases = new HashMap<String,String>(); | |||
There was a problem hiding this comment.
my suggestion:
final Map<String,String>...
robfrank
reviewed
Dec 28, 2023
| @@ -74,7 +74,7 @@ public String toString() { | |||
| return protocol + "://" + currentServer + ":" + currentPort; | |||
| } | |||
|
|
|||
| public void createUser(final String userName, final String password, final List<String> databases) { | |||
| public void createUser(final String userName, final String password, final HashMap<String,String> databases) { | |||
There was a problem hiding this comment.
again, prefer interface:
final Map<String,String
robfrank
reviewed
Dec 28, 2023
| @@ -101,6 +101,16 @@ public void createUser(final String userName, final String password, final List< | |||
| } | |||
| } | |||
|
|
|||
| public void createUser(final String userName, final String password, final List<String> databases) { | |||
|
|
|||
| HashMap<String,String> databasesWithGroups = new HashMap<String, String>(); | |||
There was a problem hiding this comment.
again:
Map<String,String> databasesWithGroups = new HashMap<String, String>();
|
Good for me ;-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
RemoteServeclass methodcreateUseris overloaded with a variant with the signatureAs for the HTTP API server command the
databasesHashMap should have keys being database names and values being a group name.The former function with a
List<String>databasesargument is still available, but its body changed so that the new method is called by it.Consoleclass methodexecuteCreateUseris updated so the newRemoteServercreateUsermethod is used. However not too robustly, and error handling is defered to theRemoteServeror eventually to theServerSecurityUserclass.So now in console the following can be done:
Motivation
Missing capability to assign group during user creation in console, even though possibl via HTTP API.
Additional Notes
It is possible to pass an empty group, but AFAIK this is also allowed in the HTTP server command.
Checklist
mvn clean packagecommand