Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rewrite MethodJoin and add test #1585

Merged
merged 2 commits into from
May 4, 2024
Merged

rewrite MethodJoin and add test #1585

merged 2 commits into from
May 4, 2024

Conversation

robfrank
Copy link
Collaborator

@robfrank robfrank commented May 4, 2024

What does this PR do?

Add test for the the new SqlMethodJoin

Motivation

The new merged method here #1584 missed test and documentation

This adds tests and rewrites the code using idiomatic Java streams and joiners

Checklist

  • I have run the build using mvn clean package command
  • My unit tests cover both failure and success scenarios

@robfrank robfrank requested a review from lvca May 4, 2024 19:28
@lvca lvca added documentation Improvements or additions to documentation enhancement New feature or request labels May 4, 2024
@lvca lvca added this to the 24.5.1 milestone May 4, 2024
Copy link
Contributor

@lvca lvca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @robfrank !!!

@mergify mergify bot merged commit a7e227d into main May 4, 2024
5 of 7 checks passed
@gramian
Copy link
Collaborator

gramian commented May 4, 2024

From me too: thanks @robfrank !

Copy link

codacy-production bot commented May 4, 2024

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
Report missing for 2b711751 0.00%
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (2b71175) Report Missing Report Missing Report Missing
Head commit (21ecc49) 64921 0 0.00%

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#1585) 14 0 0.00%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy will stop sending the deprecated coverage status from June 5th, 2024. Learn more

Footnotes

  1. Codacy didn't receive coverage data for the commit, or there was an error processing the received data. Check your integration for errors and validate that your coverage setup is correct.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants