Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#1756 migrate build and runtime in docker file to java 17 #1757

Merged
merged 1 commit into from
Oct 20, 2024
Merged

#1756 migrate build and runtime in docker file to java 17 #1757

merged 1 commit into from
Oct 20, 2024

Conversation

robfrank
Copy link
Collaborator

What does this PR do?

Migrates the build system and the runtime (docker) to java 17

Motivation

We want to move to a modern version of Java and JVM

Checklist

  • I have run the build using mvn clean package command
  • My unit tests cover both failure and success scenarios

@robfrank robfrank added enhancement New feature or request java Pull requests that update Java code labels Oct 14, 2024
@robfrank robfrank added this to the 24.11.1 milestone Oct 14, 2024
@robfrank robfrank self-assigned this Oct 14, 2024
@robfrank robfrank force-pushed the improvement/1756-migrate-to-java-17 branch from 725335e to e88f7fb Compare October 15, 2024 13:19
@robfrank robfrank force-pushed the improvement/1756-migrate-to-java-17 branch from e88f7fb to b94da2d Compare October 19, 2024 16:17
@robfrank robfrank requested a review from lvca October 20, 2024 07:27
lvca
lvca approved these changes Oct 20, 2024
View reviewed changes
Copy link
Contributor

@lvca lvca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! @robfrank could you pleas write to the discord channel that from the next release Java17 will be a requirement?

@mergify mergify bot merged commit b73ae4d into main Oct 20, 2024
5 of 9 checks passed
@gramian
Copy link
Collaborator

gramian commented Oct 20, 2024

I will update the docs accordingly

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lvca lvca lvca approved these changes

Assignees

@robfrank robfrank

Labels
enhancement New feature or request java Pull requests that update Java code
Projects
None yet
Milestone
24.11.1
Development

Successfully merging this pull request may close these issues.
3 participants
@robfrank @gramian @lvca