Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: return value of ALTER PROPERTY for DEFAULT attribute #1802

Merged
merged 1 commit into from
Oct 31, 2024
Merged

fix: return value of ALTER PROPERTY for DEFAULT attribute #1802

merged 1 commit into from
Oct 31, 2024

Conversation

gramian
Copy link
Collaborator

@gramian gramian commented Oct 30, 2024

What does this PR do?

ALTER PROPERTY is returning the evaluated attribute value for attribute type default, this is not only inconsistent with the attribute value set but also confusing as it appears to a user as if the attribute was evaluated.

Checklist

  • I have run the build using mvn clean package command
  • My unit tests cover both failure and success scenarios

@gramian gramian changed the title fox: return value of ALTER PROPERTY for DEFAULT attribute fix: return value of ALTER PROPERTY for DEFAULT attribute Oct 30, 2024
@gramian gramian requested a review from lvca October 30, 2024 18:14
@lvca lvca removed their request for review October 31, 2024 18:46
@lvca lvca added this to the 24.11.1 milestone Oct 31, 2024
lvca
lvca approved these changes Oct 31, 2024
View reviewed changes
Copy link
Contributor

@lvca lvca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@mergify mergify bot merged commit a29821a into ArcadeData:main Oct 31, 2024
2 of 3 checks passed
@gramian gramian mentioned this pull request Nov 20, 2024
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lvca lvca lvca approved these changes

Assignees

@gramian gramian

Labels
None yet
Projects
None yet
Milestone
24.11.1
Development

Successfully merging this pull request may close these issues.
2 participants
@gramian @lvca