Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move gremlin to its own module #274

Merged
merged 12 commits into from
Jan 11, 2022
Merged

Move gremlin to its own module #274

merged 12 commits into from
Jan 11, 2022

Conversation

arcade-player
Copy link
Contributor

What does this PR do?
remove DatabaseAsyncAbstractTask and move implementation do default methods on interface

move gremlin plugin away from server to gremlin module

add preliminary e2e tests on latest docker image

Motivation
#273

@arcade-player arcade-player added the enhancement New feature or request label Jan 7, 2022
@arcade-player arcade-player added this to the 22.1.1 milestone Jan 7, 2022
@arcade-player arcade-player linked an issue Jan 7, 2022 that may be closed by this pull request
@arcade-player arcade-player self-assigned this Jan 7, 2022
@lvca lvca self-requested a review January 7, 2022 17:37
@arcade-player arcade-player force-pushed the feature-273/fix_gremlin branch from 163d58a to 2a4e673 Compare January 8, 2022 23:44
@@ -1103,7 +1103,7 @@ private void createResultSet(final PostgresPortal portal, final Object... elemen
language = "cypher";
queryText = queryText.substring("{cypher}".length());
} else if (queryText.startsWith("{gremlin}")) {
language = "gremlin";
language = "com/arcadedb/server/gremlin";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will fix

@lvca lvca modified the milestones: 22.1.1, 22.1.2, 22.1.3 Jan 11, 2022
@arcade-player arcade-player force-pushed the feature-273/fix_gremlin branch from 6ea8cc7 to b661538 Compare January 11, 2022 10:57
@arcade-player arcade-player merged commit f7aa07d into main Jan 11, 2022
@lvca lvca deleted the feature-273/fix_gremlin branch May 6, 2023 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move GremlinServerPlugin from server to gremlin
2 participants