Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix for escaped characters in strings? #680

Merged
merged 1 commit into from
Dec 18, 2022
Merged

Fix for escaped characters in strings? #680

merged 1 commit into from
Dec 18, 2022

Conversation

gramian
Copy link
Collaborator

@gramian gramian commented Dec 17, 2022 •
edited
Loading

What does this PR do?

This updates the SQL grammar to handle escaped charcaters in strings.

Motivation

This issue is an important to me.

Related issues

#677

Additional Notes

Checklist

  • I have run the build using mvn clean package command (arcadedb:engine tests succeed)
  • My unit tests cover both failure and success scenarios (current tests succeed)

@lvca lvca merged commit 609ff94 into ArcadeData:main Dec 18, 2022
@lvca
Copy link
Contributor

lvca commented Dec 18, 2022

Tested against the shole suite and everything seems good to me.

@lvca lvca self-requested a review December 18, 2022 02:01
@lvca lvca added this to the 22.12.1 milestone Dec 18, 2022
@lvca lvca added the bug Something isn't working label Dec 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lvca lvca Awaiting requested review from lvca

Assignees

@gramian gramian

Labels
bug Something isn't working
Projects
None yet
Milestone
22.12.1
Development

Successfully merging this pull request may close these issues.
2 participants
@gramian @lvca