Console fixes and extensions #693
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@gramian another awesome PR, thanks! |
mergify bot
added a commit
that referenced
this pull request
Dec 23, 2024
build(deps): bump actions/setup-java from 4.5.0 to 4.6.0 Bumps [actions/setup-java](https://github.com/actions/setup-java) from 4.5.0 to 4.6.0. Release notes *Sourced from [actions/setup-java's releases](https://github.com/actions/setup-java/releases).* > v4.6.0 > ------ > > What's Changed > -------------- > > **Add-ons:** > > * Add Support for JetBrains Runtime by [`@gmitch215`](https://github.com/gmitch215) in [actions/setup-java#637](https://redirect.github.com/actions/setup-java/pull/637) > > ``` > - name: Checkout > uses: actions/checkout@v4 > - name: Setup-java > uses: actions/setup-java@v4 > with: > distribution: ‘jetbrains’ > java-version: '21' > > ``` > > **Bug fixes:** > > * Fix Ubuntu-latest CI failures by [`@mahabaleshwars`](https://github.com/mahabaleshwars) in [actions/setup-java#693](https://redirect.github.com/actions/setup-java/pull/693) > > New Contributors > ---------------- > > * [`@gmitch215`](https://github.com/gmitch215) made their first contribution in [actions/setup-java#637](https://redirect.github.com/actions/setup-java/pull/637) > > **Full Changelog**: <actions/setup-java@v4...v4.6.0> Commits * [`7a6d8a8`](actions/setup-java@7a6d8a8) Add Support for JetBrains Runtime ([#637](https://redirect.github.com/actions/setup-java/issues/637)) * [`7136edc`](actions/setup-java@7136edc) Fix sbt and x86 CI failures on Ubuntu-24 ([#693](https://redirect.github.com/actions/setup-java/issues/693)) * See full diff in [compare view](actions/setup-java@8df1039...7a6d8a8) [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- Dependabot commands and options You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
console.shThe problem was: when calling the console with anargument which contains spaces, these were removed by the shell script, for example:
did not work, as the space between
loadandtestwas automatically removed. 986fcc0 fixes this.Console.javaCalling a script from the shell can result in hanging of the console. This is fixed by forcing an
exitcommand at the end of a non-interactive session. fb500e2 fixes this.Console.javaEntering multiple whitespaces in the console prompt results in an (SQL) error. To fix this the
trimof the currently parsed line is moved out of theifblock deciding if a command is empty, so a white-sapce only command is skipped.f044e85 fixes this.
Console.javaI added a comment "command" which is introduced by
--. This is useful for longer scripts. 5f2d4b9 adds this.Console.javaI updated the help message to the current state. 3d41636 does that.
Motivation
All these changes result from loading a script via console.
Related issues
#611
Additional Notes
Anything else we should know when reviewing?
Checklist
mvn clean packagecommand (up to and including theconsolestep tests pass)