Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add readonly default server group #987

Merged
merged 1 commit into from
Mar 30, 2023
Merged

Add readonly default server group #987

merged 1 commit into from
Mar 30, 2023

Conversation

gramian
Copy link
Collaborator

@gramian gramian commented Mar 30, 2023 •
edited
Loading

What does this PR do?

A default server group is added to the config which just permits reading and is thus pretty safe.

Motivation

Volume constraints of the config folder in the Docker image

Related Issue

#985

Checklist

  • I have run the build using mvn clean package command
  • My unit tests cover both failure and success scenarios

@lvca lvca self-requested a review March 30, 2023 20:49
@lvca lvca added this to the 23.3.1 milestone Mar 30, 2023
@lvca lvca added the enhancement New feature or request label Mar 30, 2023
@lvca lvca merged commit 911b251 into ArcadeData:main Mar 30, 2023
@lvca
Copy link
Contributor

lvca commented Mar 30, 2023

Thanks @gramian!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lvca lvca Awaiting requested review from lvca

Assignees

@gramian gramian

Labels
enhancement New feature or request
Projects
None yet
Milestone
23.3.1
Development

Successfully merging this pull request may close these issues.
2 participants
@gramian @lvca