refactor!: replaced the base action.

RotationSolver.Basic/Actions/ActionBasicInfo.cs

@@ -12,7 +12,7 @@ public struct ActionBasicInfo
         (uint)ActionID.BlastChargePvP,
     ];
 
-    private readonly IBaseActionNew _action;
+    private readonly IBaseAction _action;
     public readonly string Name => _action.Action.Name;
     public readonly uint ID => _action.Action.RowId;
     public readonly uint IconID => ID == (uint)ActionID.SprintPvE ? 104u : _action.Action.Icon;
@@ -52,7 +52,7 @@ public readonly bool IsOnSlot
 
 
 
-    public ActionBasicInfo(IBaseActionNew action, bool isDutyAction)
+    public ActionBasicInfo(IBaseAction action, bool isDutyAction)
     {
         _action = action;
         IsGeneralGCD = _action.Action.IsGeneralGCD();

RotationSolver.Basic/Actions/ActionCooldownInfo.cs

@@ -5,7 +5,7 @@
 namespace RotationSolver.Basic.Actions;
 public readonly struct ActionCooldownInfo
 {
-    private readonly IBaseActionNew _action;
+    private readonly IBaseAction _action;
     public byte CoolDownGroup { get; }
 
     unsafe RecastDetail* CoolDownDetail => ActionManager.Instance()->GetRecastGroupDetail(CoolDownGroup - 1);
@@ -61,7 +61,7 @@ public readonly struct ActionCooldownInfo
     float RecastTimeElapsedOneChargeRaw => RecastTimeElapsedRaw % RecastTimeOneChargeRaw;
 
 
-    public ActionCooldownInfo(IBaseActionNew action)
+    public ActionCooldownInfo(IBaseAction action)
     {
         _action = action;
         CoolDownGroup = _action.Action.GetCoolDownGroup();

RotationSolver.Basic/Actions/ActionSetting.cs

@@ -5,6 +5,7 @@
 /// </summary>
 public struct ActionSetting()
 {
+    public bool TargetStatusFromSelf { get; set; } = true;
     public StatusID[]? TargetStatus { get; set; } = null;
     public Func<GameObject, bool> CanTarget { get; set; } = t => true;
     internal ActionID[]? ComboIdsNot { get; set; }
@@ -23,5 +24,5 @@ public struct ActionSetting()
     public Func<bool>? ActionCheck { get; set; } = null;
 
     public bool IsFriendly { get; set; }
-    public TargetType Type { get; set; } = TargetType.Big;
+    public TargetType TargetType { get; set; } = TargetType.Big;
 }

RotationSolver.Basic/Actions/ActionTargetInfo.cs

@@ -9,7 +9,7 @@
 
 namespace RotationSolver.Basic.Actions;
 
-public struct ActionTargetInfo(IBaseActionNew _action)
+public struct ActionTargetInfo(IBaseAction _action)
 {
     public readonly bool TargetArea => _action.Action.TargetArea;
 
@@ -101,7 +101,8 @@ private readonly bool CheckStatus(GameObject gameObject)
     {
         if (_action.Setting.TargetStatus == null || !_action.Config.ShouldCheckStatus) return true;
 
-        return gameObject.WillStatusEndGCD(_action.Config.StatusGcdCount, 0, true, _action.Setting.TargetStatus);
+        return gameObject.WillStatusEndGCD(_action.Config.StatusGcdCount, 0,
+            _action.Setting.TargetStatusFromSelf, _action.Setting.TargetStatus);
     }
 
     private readonly bool CheckResistance(GameObject gameObject)
@@ -156,7 +157,7 @@ private readonly bool CheckTimeToKill(GameObject gameObject)
         }
 
         var targets = GetMostCanTargetObjects(canTargets, canAffects, _action.Config.AoeCount);
-        var target = FindTargetByType(targets, _action.Setting.Type);
+        var target = FindTargetByType(targets, _action.Setting.TargetType);
         if (target == null) return null;
 
         return new(target, [.. GetAffects(target, canAffects)], target.Position);
@@ -165,7 +166,7 @@ private readonly bool CheckTimeToKill(GameObject gameObject)
     private readonly TargetResult? FindTargetArea(IEnumerable<GameObject> canTargets, IEnumerable<GameObject> canAffects,
         float range, PlayerCharacter player)
     {
-        if (_action.Setting.Type is TargetType.Move)
+        if (_action.Setting.TargetType is TargetType.Move)
         {
             return FindTargetAreaMove(range);
         }

RotationSolver.Basic/Actions/BaseActionNew.cs → RotationSolver.Basic/Actions/BaseAction.cs

@@ -4,7 +4,7 @@
 using Action = Lumina.Excel.GeneratedSheets.Action;
 
 namespace RotationSolver.Basic.Actions;
-public class BaseActionNew : IBaseActionNew
+public class BaseAction : IBaseAction
 {
     public TargetResult? Target { get; private set; } = null;
 
@@ -70,21 +70,14 @@ public virtual unsafe uint MPNeed
 
     public ActionConfig Config { get; set; }
 
-    public BaseActionNew(ActionID actionID, bool isDutyAction)
+    public BaseAction(ActionID actionID, bool isDutyAction)
     {
         Action = Service.GetSheet<Action>().GetRow((uint)actionID)!;
         TargetInfo = new(this);
         Info = new(this, isDutyAction);
         Cooldown = new(this);
 
-        //TODO: better target type check.
-        //TODO: better friendly check.
-        Setting = new()
-        {
-            IsFriendly = Action.CanTargetFriendly,
-        };
-
-        //TODO: load the config from the 
+        Setting = new();
         Config = new();
     }