Skip to content
This repository has been archived by the owner on Aug 28, 2024. It is now read-only.

Commit

Permalink
fix: make some methods public.
Browse files Browse the repository at this point in the history
  • Loading branch information
ArchiDog1998 committed Feb 27, 2024
1 parent 86264c0 commit 3bafba6
Show file tree
Hide file tree
Showing 2 changed files with 19 additions and 5 deletions.
2 changes: 1 addition & 1 deletion Directory.Build.props
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
<TargetFramework>net7.0-windows</TargetFramework>
<ImplicitUsings>enable</ImplicitUsings>
<Authors>ArchiTed</Authors>
<Version>4.0.3.4</Version>
<Version>4.0.3.5</Version>
<PlatformTarget>x64</PlatformTarget>
<Platforms>AnyCPU</Platforms>
<LangVersion>latest</LangVersion>
Expand Down
22 changes: 18 additions & 4 deletions RotationSolver.Basic/Helpers/ObjectHelper.cs
Original file line number Diff line number Diff line change
Expand Up @@ -262,7 +262,12 @@ internal static bool CanInterrupt(this GameObject o)

internal static bool IsDummy(this BattleChara obj) => obj?.NameId == 541;

internal static bool IsBossFromTTK(this BattleChara obj)
/// <summary>
/// Is target a boss depends on the ttk.
/// </summary>
/// <param name="obj">the object.</param>
/// <returns></returns>
public static bool IsBossFromTTK(this BattleChara obj)
{
if (obj == null) return false;

Expand All @@ -273,8 +278,12 @@ internal static bool IsBossFromTTK(this BattleChara obj)

return false;
}

internal static bool IsBossFromIcon(this BattleChara obj)
/// <summary>
/// Is target a boss depends on the icon.
/// </summary>
/// <param name="obj">the object.</param>
/// <returns></returns>
public static bool IsBossFromIcon(this BattleChara obj)
{
if (obj == null) return false;

Expand All @@ -286,7 +295,12 @@ internal static bool IsBossFromIcon(this BattleChara obj)
return false;
}

internal static bool IsDying(this BattleChara b)
/// <summary>
/// Is object dying.
/// </summary>
/// <param name="b"></param>
/// <returns></returns>
public static bool IsDying(this BattleChara b)
{
if (b == null) return false;
if (b.IsDummy() && !Service.Config.ShowTargetTimeToKill) return false;
Expand Down

0 comments on commit 3bafba6

Please sign in to comment.