fix: Reduced the frequency of use of GetAuthors.

ArchiDog1998 · Apr 11, 2023 · 5989a8a · 5989a8a
1 parent af271c0
commit 5989a8a
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 8 deletions.
diff --git a/RotationSolver/RotationHelper.cs b/RotationSolver/RotationHelper.cs
@@ -9,7 +9,7 @@ namespace RotationSolver;
 internal static class RotationHelper
 {
     public static string[] AllowedAssembly { get; private set; } = new string[0];
-
+    static readonly SortedList<Assembly, string> _authors = new SortedList<Assembly, string>();
     public static async void LoadList()
     {
         using (var client = new HttpClient())
@@ -46,16 +46,14 @@ public static Vector4 GetColor(this ICustomRotation rotation)
     public static bool IsBeta(this ICustomRotation rotation)
         => rotation.GetType().GetCustomAttribute<BetaRotationAttribute>() != null;
 
-
-    public static string GetAuthor(this ICustomRotation rotation)
-        => rotation.GetType().Assembly.GetAuthor();
-
     public static string GetAuthor(this Assembly assembly)
     {
+        if (_authors.TryGetValue(assembly, out var author)) return author;
         try
         {
             var name = assembly.GetName().Name;
-            return (RotationLoadContext.AssemblyPaths.TryGetValue(name, out var path) 
+            return _authors[assembly] = 
+                (RotationLoadContext.AssemblyPaths.TryGetValue(name, out var path) 
                 ? FileVersionInfo.GetVersionInfo(path)?.CompanyName : name)
                 ?? name ?? "Unknown";
         }

diff --git a/RotationSolver/UI/ImGuiHelper.cs b/RotationSolver/UI/ImGuiHelper.cs
@@ -456,7 +456,7 @@ public unsafe static void Display(this ICustomRotation rotation, ICustomRotation
             ImGui.SameLine();
 
             ImGui.PushStyleColor(ImGuiCol.Text, rotation.GetColor());
-            ImGui.Text(rotation.GetAuthor());
+            ImGui.Text(rotation.GetType().Assembly.GetName().Name);
             if (!rotation.IsAllowed(out _))
             {
                 var showStr = string.Format(LocalizationManager.RightLang.ConfigWindow_Helper_HighEndWarning, rotation)

diff --git a/RotationSolver/UI/RotationConfigWindow_RotationDev.cs b/RotationSolver/UI/RotationConfigWindow_RotationDev.cs
@@ -56,7 +56,6 @@ private void DrawRotationDevTab()
             }
 
             ImGui.EndChild();
-
         }
     }
 }
-Original file line number
+Diff line change
@@ Expand Up / @@ -56,7 +56,6 @@ private void DrawRotationDevTab() @@
                 }
                 ImGui.EndChild();
             }
         }
     }