Skip to content
This repository has been archived by the owner on Aug 28, 2024. It is now read-only.

Commit

Permalink
fix: removed the tank buster check.
Browse files Browse the repository at this point in the history
  • Loading branch information
ArchiDog1998 committed Apr 30, 2023
1 parent bf7b72c commit 5afb0e0
Show file tree
Hide file tree
Showing 8 changed files with 18 additions and 38 deletions.
8 changes: 8 additions & 0 deletions Resources/AnimationLockTime.json
Original file line number Diff line number Diff line change
Expand Up @@ -111,15 +111,23 @@
"24289": 0.6,
"24290": 0.6,
"24291": 0.6,
"24292": 0.6,
"24294": 0.6,
"24295": 0.70000005,
"24296": 0.6,
"24297": 0.6,
"24298": 0.6,
"24299": 0.6,
"24301": 0.6,
"24302": 0.6,
"24303": 0.6,
"24304": 0.6,
"24305": 0.6,
"24310": 0.6,
"24312": 0.1,
"24313": 0.6,
"24315": 0.6,
"24316": 0.6,
"25751": 0.6,
"25752": 0.6,
"25753": 1.15,
Expand Down
6 changes: 5 additions & 1 deletion Resources/HostileCastingArea.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,10 @@
[
9523,
13314,
13343,
13389,
13440,
13461,
13462
13462,
31835
]
16 changes: 1 addition & 15 deletions Resources/HostileCastingTank.json
Original file line number Diff line number Diff line change
@@ -1,15 +1 @@
[
13364,
13365,
13367,
13371,
13375,
13385,
13388,
13438,
13444,
13452,
13454,
13462,
13475
]
[]
1 change: 0 additions & 1 deletion RotationSolver.Basic/Configuration/PluginConfiguration.cs
Original file line number Diff line number Diff line change
Expand Up @@ -165,7 +165,6 @@ public class PluginConfiguration : IPluginConfiguration
public bool AutoUpdateLibs = true;
public string[] OtherLibs = Array.Empty<string>();

public bool RecordCastingTank = true;
public bool RecordCastingArea = true;

public List<TargetingType> TargetingTypes { get; set; } = new List<TargetingType>();
Expand Down
6 changes: 3 additions & 3 deletions RotationSolver.Basic/Rotations/Basic/SGE_Base.cs
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,7 @@ protected static bool AddersgallEndAfterGCD(uint gctCount = 0, float offset = 0)

public static IBaseAction Eukrasia { get; } = new BaseAction(ActionID.Eukrasia, ActionOption.Heal)
{
ActionCheck = b => !JobGauge.Eukrasia,
ActionCheck = b => !HasEukrasia,
};

public static IBaseAction Soteria { get; } = new BaseAction(ActionID.Soteria, ActionOption.Heal);
Expand Down Expand Up @@ -122,12 +122,12 @@ protected static bool AddersgallEndAfterGCD(uint gctCount = 0, float offset = 0)
},
};

public static IBaseAction Haima { get; } = new BaseAction(ActionID.Haima, ActionOption.Heal)
public static IBaseAction Haima { get; } = new BaseAction(ActionID.Haima, ActionOption.Defense)
{
ChoiceTarget = TargetFilter.FindAttackedTarget,
};

public static IBaseAction EukrasianDiagnosis { get; } = new BaseAction(ActionID.EukrasianDiagnosis, ActionOption.Heal)
public static IBaseAction EukrasianDiagnosis { get; } = new BaseAction(ActionID.EukrasianDiagnosis, ActionOption.Defense)
{
ChoiceTarget = TargetFilter.FindAttackedTarget,
};
Expand Down
2 changes: 1 addition & 1 deletion RotationSolver/UI/RotationConfigWindow_Action.cs
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ private void DrawActionList()
{
if (ImGui.CollapsingHeader(pair.Key))
{
foreach (var item in pair)
foreach (var item in pair.OrderBy(t => t.ID))
{
item.Display(ActiveAction == item);
ImGui.Separator();
Expand Down
5 changes: 0 additions & 5 deletions RotationSolver/UI/RotationConfigWindow_List.cs
Original file line number Diff line number Diff line change
Expand Up @@ -181,11 +181,6 @@ private void DrawListTab()

DrawParamTabItem(LocalizationManager.RightLang.ConfigWindow_List_HostileCastingTank, DrawHostileCastingTank, () =>
{
DrawCheckBox("Record", ref Service.Config.RecordCastingTank, Service.Default.RecordCastingTank);

ImGui.SameLine();
ImGuiHelper.Spacing();

ImGui.SetNextItemWidth(200);
ImGuiHelper.SearchCombo("##AddCastingTank",
LocalizationManager.RightLang.ConfigWindow_Param_AddOne,
Expand Down
12 changes: 0 additions & 12 deletions RotationSolver/Watcher.cs
Original file line number Diff line number Diff line change
Expand Up @@ -98,18 +98,6 @@ private static void ActionFromEnemy(uint sourceId, ActionEffectSet set)
OtherConfiguration.SaveHostileCastingArea();
}
}
else if (DataCenter.PartyTanks.Any(p => p.ObjectId == set.Target?.ObjectId)
|| set.TargetEffects.Any(e =>
DataCenter.PartyTanks.Any(p => p.ObjectId == e.Target?.ObjectId)
&& e.GetSpecificTypeEffect(ActionEffectType.Damage, out var effect)
&& (effect.Value > 0 || (effect.Param0 & 6) == 6)))
{
if (Service.Config.RecordCastingTank)
{
OtherConfiguration.HostileCastingTank.Add(set.Action.RowId);
OtherConfiguration.SaveHostileCastingTank();
}
}
}
}
}
Expand Down

0 comments on commit 5afb0e0

Please sign in to comment.