fix: clean code.

RotationSolver.Basic/Actions/BaseAction_ActionInfo.cs

@@ -78,7 +78,6 @@ public unsafe virtual bool CanUse(out IAction act, CanUseOption option = CanUseO
         Target = player;
 
         if (!option.HasFlag(CanUseOption.SkipDisable) && !IsEnabled) return false;
-
 
         if (DataCenter.DisabledAction != null && DataCenter.DisabledAction.Contains(ID)) return false;
 

RotationSolver/UI/PainterManager.cs

@@ -9,78 +9,6 @@ namespace RotationSolver.UI;
 
 internal static class PainterManager
 {
-    class PositionalDrawing : Drawing3DPoly
-    {
-        Drawing3DCircularSectorO _noneCir, _flankCir, _rearCir;
-
-        public EnemyPositional Positional { get; set; }
-
-        public GameObject Target { get; set; }
-
-        public PositionalDrawing()
-        {
-            var right = ImGui.ColorConvertFloat4ToU32(new Vector4(1, 1, 1, 0.15f));
-            var wrong = ImGui.ColorConvertFloat4ToU32(new Vector4(0.3f, 0.8f, 0.2f, 0.15f));
-
-            _noneCir = new Drawing3DCircularSectorO(null, 3, wrong, 2);
-
-            _flankCir = new Drawing3DCircularSectorO(null, 3, wrong, 2, XIVPainter.Enum.RadiusInclude.IncludeBoth,
-                new Vector2(MathF.PI * 0.25f, MathF.PI / 2), new Vector2(MathF.PI * 1.25f, MathF.PI / 2));
-            _rearCir = new Drawing3DCircularSectorO(null, 3, wrong, 2, XIVPainter.Enum.RadiusInclude.IncludeBoth,
-                new Vector2(MathF.PI * 0.75f, MathF.PI / 2));
-
-            _noneCir.InsideColor = _flankCir.InsideColor = _rearCir.InsideColor = right;
-
-            SubItems = new IDrawing3D[] { _noneCir, _flankCir, _rearCir };
-        }
-
-        public override void UpdateOnFrame(XIVPainter.XIVPainter painter)
-        {
-            if (Target == null || !Target.IsNPCEnemy())
-            {
-                _flankCir.Target = null;
-                _rearCir.Target = null;
-                _noneCir.Target = null;
-            }
-            else
-            {
-                var pos = Positional;
-                if (!Target.HasPositional() || Player.Available && Player.Object.HasStatus(true, CustomRotation.TrueNorth.StatusProvide))
-                {
-                    pos = EnemyPositional.None;
-                }
-                switch (pos)
-                {
-                    case EnemyPositional.Flank when Service.Config.DrawPositional:
-                        _flankCir.Target = Target;
-                        _rearCir.Target = null;
-                        _noneCir.Target = null;
-                        break;
-
-                    case EnemyPositional.Rear when Service.Config.DrawPositional:
-                        _flankCir.Target = null;
-                        _rearCir.Target = Target;
-                        _noneCir.Target = null;
-                        break;
-
-                    case EnemyPositional.None when Service.Config.DrawMeleeRange:
-                        _flankCir.Target = null;
-                        _rearCir.Target = null;
-                        _noneCir.Target = Target;
-                        break;
-
-                    default:
-                        _flankCir.Target = null;
-                        _rearCir.Target = null;
-                        _noneCir.Target = null;
-                        break;
-                }
-            }
-
-            base.UpdateOnFrame(painter);
-        }
-    }
-
     class TargetDrawing : Drawing3DPoly
     {
         Drawing3DCircularSector _target;
@@ -194,7 +122,6 @@ public override void UpdateOnFrame(XIVPainter.XIVPainter painter)
     }
 
     internal static XIVPainter.XIVPainter _painter;
-    static PositionalDrawing _positional = new();
     static DrawingHighlightHotbar _highLight = new();
 
     public static HashSet<uint> ActionIds => _highLight.ActionIds;
@@ -209,7 +136,6 @@ public static void Init()
     {
         _painter = XIVPainter.XIVPainter.Create(Svc.PluginInterface, "RotationSolverOverlay");
 
-        _positional = new();
         _highLight = new();
 
         _painter.DrawingHeight = Service.Config.DrawingHeight;
@@ -253,7 +179,7 @@ public static void Init()
             movingTarget.To = tar.Value;
         };
 
-        _painter.AddDrawings(_positional, _highLight, annulus, movingTarget, new TargetDrawing(), new TargetText());
+        _painter.AddDrawings(_highLight, annulus, movingTarget, new TargetDrawing(), new TargetText());
 
 #if DEBUG
         //try
@@ -289,17 +215,6 @@ public static void Init()
 #endif
     }
 
-    public static void UpdatePositional(EnemyPositional positional, GameObject target)
-    {
-        _positional.Target = target;
-        _positional.Positional = positional;
-    }
-
-    public static void ClearPositional()
-    {
-        _positional.Target = null;
-    }
-
     public static void Dispose()
     {
         _painter?.Dispose();

RotationSolver/Updaters/ActionUpdater.cs

@@ -22,6 +22,11 @@ internal static class ActionUpdater
     internal static IAction WrongAction { get; set; }
     static Random _wrongRandom = new();
 
+    internal static void Dispose()
+    {
+        SetAction(0);
+    }
+
     internal static void UpdateNextAction()
     {
         PlayerCharacter localPlayer = Player.Object;
@@ -66,10 +71,10 @@ internal static void UpdateNextAction()
         }
 
         WrongAction = NextAction = NextGCDAction = null;
-        PainterManager.ClearPositional();
     }
 
     private static void SetAction(uint id) => Svc.PluginInterface.GetOrCreateData("Avarice.ActionOverride", () => new List<uint>() { id })[0] = id;
+
     internal unsafe static void UpdateActionInfo()
     {
         SetAction(NextGCDAction?.AdjustedID ?? 0);

RotationSolver/Updaters/MajorUpdater.cs

@@ -175,5 +175,6 @@ public static void Dispose()
         PreviewUpdater.Dispose();
         ActionSequencerUpdater.SaveFiles();
         SocialUpdater.Disable();
+        ActionUpdater.Dispose();
     }
 }