fix: changed some comments

ArchiDog1998 · Apr 12, 2023 · 6c2ae2f · 6c2ae2f
1 parent a03555d
commit 6c2ae2f
Show file tree

Hide file tree

Showing 4 changed files with 37 additions and 10 deletions.
diff --git a/RotationSolver.Basic/Data/ActionEffectHeader.cs b/RotationSolver.Basic/Data/ActionEffectHeader.cs
@@ -6,15 +6,38 @@ namespace RotationSolver.Basic.Data;
 [StructLayout(LayoutKind.Sequential, Pack = 1)]
 public unsafe struct ActionEffectHeader
 {
-    public ulong animationTargetId;  // who the animation targets
-    public uint actionId; // what the casting player casts, shown in battle log / ui
+    /// <summary>
+    /// who the animation targets
+    /// </summary>
+    public ulong animationTargetId;
+
+    /// <summary>
+    /// what the casting player casts, shown in battle log / ui
+    /// </summary>
+    public uint actionId;
+
+    /// <summary>
+    /// Number of the effect
+    /// </summary>
     public uint globalEffectCounter;
     public float animationLockTime;
     public uint SomeTargetID;
-    public ushort SourceSequence; // 0 = initiated by server, otherwise corresponds to client request sequence id
+
+    /// <summary>
+    /// 0 = initiated by server, otherwise corresponds to client request sequence id
+    /// </summary>
+    public ushort SourceSequence; 
     public ushort rotation;
     public ushort actionAnimationId;
-    public byte variation; // animation
+
+    /// <summary>
+    /// animation
+    /// </summary>
+    public byte variation; 
+
+    /// <summary>
+    /// Action Type
+    /// </summary>
     public ActionType actionType;
     public byte unknown20;
     public byte NumTargets; // machina calls it 'effectCount', but it is misleading imo

diff --git a/RotationSolver.Basic/Data/ActionID.cs b/RotationSolver.Basic/Data/ActionID.cs
@@ -1,5 +1,8 @@
 namespace RotationSolver.Basic.Data;
 
+/// <summary>
+/// The id of the action
+/// </summary>
 public enum ActionID : uint
 {
     None = 0,

diff --git a/RotationSolver.Basic/RotationSolver.Basic.csproj b/RotationSolver.Basic/RotationSolver.Basic.csproj
@@ -13,6 +13,12 @@
 	  <PackageReadmeFile>README.md</PackageReadmeFile>
 	  <GenerateDocumentationFile>True</GenerateDocumentationFile>
   </PropertyGroup>
+  <PropertyGroup Condition="'$(Configuration)|$(Platform)'=='Debug|AnyCPU'">
+    <NoWarn>1701;1702;1591</NoWarn>
+  </PropertyGroup>
+  <PropertyGroup Condition="'$(Configuration)|$(Platform)'=='Release|AnyCPU'">
+    <NoWarn>1701;1702;1591</NoWarn>
+  </PropertyGroup>
 
   <ItemGroup>
 	  <Using Include="System.ComponentModel" />

diff --git a/RotationSolver.Basic/Rotations/CustomRotation_Actions.cs b/RotationSolver.Basic/Rotations/CustomRotation_Actions.cs
@@ -95,18 +95,13 @@ internal RoleAction(ActionID actionID, JobRole[] roles, bool isFriendly = false,
         {
             StatusID.SuperBolide, StatusID.HallowedGround,
             StatusID.Rampart, StatusID.Bulwark,
-            //原初的直觉和血气
             StatusID.RawIntuition, StatusID.BloodWhetting,
-            //复仇
             StatusID.Vengeance,
-            //预警
             StatusID.Sentinel,  
-            //暗影墙
             StatusID.ShadowWall,
-            //星云
             StatusID.Nebula,
 
-            //TODO:BLU的减伤技能
+            //TODO:BLU Debuff
         }.Union(StatusHelper.NoNeedHealingStatus).ToArray(),
         ActionCheck = BaseAction.TankDefenseSelf,
     };