fix: changed the access of some properties.

Directory.Build.props

@@ -3,7 +3,7 @@
 		<TargetFramework>net7.0-windows</TargetFramework>
 		<ImplicitUsings>enable</ImplicitUsings>
 		<Authors>ArchiTed</Authors>
-		<Version>2.2.9</Version>
+		<Version>2.2.12</Version>
 		<PlatformTarget>x64</PlatformTarget>
 		<Platforms>AnyCPU</Platforms>
 

RotationSolver.Basic/Actions/BaseAction_ActionInfo.cs

@@ -6,15 +6,15 @@ public partial class BaseAction
 {
     public float Range => ActionManager.GetActionRange(ID);
 
-    internal ActionID[] ComboIdsNot { private get; set; } = null;
+    internal ActionID[] ComboIdsNot { private get; init; } = null;
 
-    internal ActionID[] ComboIds { private get; set; } = null;
+    internal ActionID[] ComboIds { private get; init; } = null;
 
-    public StatusID[] StatusProvide { get; internal set; } = null;
+    public StatusID[] StatusProvide { get; init; } = null;
 
-    public virtual StatusID[] StatusNeed { get; internal set; } = null;
+    public virtual StatusID[] StatusNeed { get; init; } = null;
 
-    public Func<BattleChara, bool> ActionCheck { get; internal set; } = null;
+    public Func<BattleChara, bool> ActionCheck { get; init; } = null;
 
     private bool WillCooldown
     {

RotationSolver.Basic/Actions/BaseAction_BasicInfo.cs

@@ -15,7 +15,7 @@ public partial class BaseAction : IBaseAction
     public bool IsGeneralGCD => _option.HasFlag(ActionOption.GeneralGCD);
     public bool IsRealGCD => _option.HasFlag(ActionOption.RealGCD);
 
-    internal Func<uint> GetDotGcdCount { private get; set; }
+    public Func<uint> GetDotGcdCount { private get; init; }
 
     /// <summary>
     /// EnoughLevel for using.

RotationSolver.Basic/Actions/BaseAction_Target.cs

@@ -6,7 +6,7 @@ namespace RotationSolver.Basic.Actions;
 
 public partial class BaseAction
 {
-    public byte AOECount { private get; set; } = 3;
+    public byte AOECount { private get; init; } = 3;
 
     public bool IsTargetDying => Target?.IsDying() ?? false;
 
@@ -24,19 +24,19 @@ public partial class BaseAction
 
     private Func<IEnumerable<BattleChara>, bool, BattleChara> _choiceTarget = null;
 
-    internal Func<IEnumerable<BattleChara>, bool, BattleChara> ChoiceTarget
+    public Func<IEnumerable<BattleChara>, bool, BattleChara> ChoiceTarget
     {
         private get
         {
             if (_choiceTarget != null) return _choiceTarget;
             return IsFriendly ? TargetFilter.DefaultChooseFriend : TargetFilter.DefaultFindHostile;
         }
-        set => _choiceTarget = value;
+        init => _choiceTarget = value;
     }
 
-    internal Func<IEnumerable<BattleChara>, IEnumerable<BattleChara>> FilterForHostiles { private get; set; } = null;
+    public Func<IEnumerable<BattleChara>, IEnumerable<BattleChara>> FilterForHostiles { private get; init; } = null;
 
-    public StatusID[] TargetStatus { get; internal set; } = null;
+    public StatusID[] TargetStatus { get; init; } = null;
 
     internal static bool TankDefenseSelf(BattleChara chara)
     {

RotationSolver.Basic/Actions/IBaseAction.cs

@@ -142,11 +142,6 @@ public interface IBaseAction : IAction
         /// </summary>
         bool IsTargetDying { get; }
 
-        /// <summary>
-        /// If this is an aoe action, how many hostile target would want to attack on, when you use this action.
-        /// </summary>
-        byte AOECount { set; }
-
         /// <summary>
         /// Is this action's target type is target only one.
         /// </summary>

RotationSolver.Basic/Helpers/IActionHelper.cs

@@ -48,6 +48,7 @@ internal static bool IsLastAction(params ActionID[] ids)
 
     public static bool IsTheSameTo(this IAction action, bool isAdjust, params IAction[] actions)
     {
+        if (action == null) return false;
         return IsActionID(isAdjust ? (ActionID)action.AdjustedID : (ActionID)action.ID, GetIDFromActions(isAdjust, actions));
     }
 

RotationSolver.Basic/Rotations/CustomRotation_BasicInfo.cs

@@ -78,6 +78,20 @@ private protected CustomRotation()
     {
         IconID = IconSet.GetJobIcon(this);
         Configs = CreateConfiguration();
+
+        try
+        {
+            for (byte i = 0; i < 3; i++)
+            {
+                Ability(i, GCD(i, true, true), out _, true, true);
+            }
+            IsValid = true;
+        }
+        catch (Exception ex) 
+        {
+            PluginLog.Warning(ex, $"The rotation \"{GetType().FullName}\" is not valid, please tell to the author");
+            IsValid = false;
+        }
     }
 
     protected virtual IRotationConfigSet CreateConfiguration()

RotationSolver.Basic/Rotations/CustomRotation_Invoke.cs

@@ -70,7 +70,7 @@ public bool TryInvoke(out IAction newAction, out IAction gcdAction)
         }
         catch(Exception ex)
         {
-            if(_lastException != ex)
+            if(_lastException?.GetType() != ex.GetType())
             {
                 PluginLog.Error(ex, "Failed to invoke the next action");
             }

RotationSolver/Localization/Strings.cs

@@ -275,7 +275,7 @@ internal partial class Strings
     public string ConfigWindow_Control_NeedToEnable { get; set; } = " (Need to enable)";
     public string ConfigWindow_Control_ClickToUse { get; set; } = "Click to use it!";
     public string ConfigWindow_Rotation_BetaRotation { get; set; } = "Beta Rotation!";
-    public string ConfigWindow_Rotation_InvalidRotation { get; set; } = "Invalid Rotation! Please contact to the author!";
+    public string ConfigWindow_Rotation_InvalidRotation { get; set; } = "Invalid Rotation! \nPlease update to the latest version or contact to the {0}!";
     public string ConfigWindow_Rotation_ResetToDefault { get; set; } = "Click to reset the rotation configuration to default!";
     #endregion
 

RotationSolver/UI/ImGuiHelper.cs

@@ -418,7 +418,7 @@ public unsafe static void Display(this ICustomRotation rotation, ICustomRotation
                         ImGui.Text(e.Message);
                         e = e.InnerException;
                     }
-                    ImGui.TextWrapped(ex.StackTrace);
+                    ImGui.Text(ex.StackTrace);
                 }
             }, "Popup" + rotation.GetHashCode().ToString());
         },
@@ -459,9 +459,10 @@ public unsafe static void Display(this ICustomRotation rotation, ICustomRotation
             ImGui.Text(rotation.GetType().Assembly.GetName().Name);
             if(!rotation.IsValid)
             {
-                HoveredString(LocalizationManager.RightLang.ConfigWindow_Rotation_InvalidRotation);
+                HoveredString(string.Format(LocalizationManager.RightLang.ConfigWindow_Rotation_InvalidRotation, 
+                    rotation.GetType().Assembly.GetInfo().Author));
             }
-            if (!rotation.IsAllowed(out _))
+            else if (!rotation.IsAllowed(out _))
             {
                 var showStr = string.Format(LocalizationManager.RightLang.ConfigWindow_Helper_HighEndWarning, rotation)
                 + string.Join("", SocialUpdater.HighEndDuties.Select(x => x.PlaceName?.Value?.Name.ToString())

RotationSolver/Updaters/RotationUpdater.cs

@@ -116,7 +116,12 @@ private static void LoadRotationsFromLocal(string relayFolder)
         var directories = Service.Config.OtherLibs
             .Where(Directory.Exists)
             //.Append(Path.GetDirectoryName(Assembly.GetAssembly(typeof(ICustomRotation)).Location))
-            .Append(relayFolder);
+#if DEBUG
+            //.Append(relayFolder)
+#else
+            .Append(relayFolder)
+#endif
+            ;
 
         var assemblies = from dir in directories
                          where Directory.Exists(dir)