fix: Removed unnecessary file.Dispose() after loading with using. Oops.

ArchiDog1998 · May 16, 2023 · 9f57e24 · 9f57e24
1 parent 54b902c
commit 9f57e24
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 15 deletions.
diff --git a/RotationSolver/Helpers/RotationLoadContext.cs b/RotationSolver/Helpers/RotationLoadContext.cs
@@ -76,9 +76,8 @@ internal Assembly LoadFromFile(string filePath)
             using var pdbFile = File.Open(pdbPath, FileMode.Open, FileAccess.Read, FileShare.Read);
             var assembly = LoadFromStream(file, pdbFile);
 
-            file.Dispose();
-            pdbFile.Dispose();
             return assembly;
         }
+
     }
 }
diff --git a/RotationSolver/Updaters/RotationUpdater.cs b/RotationSolver/Updaters/RotationUpdater.cs
@@ -151,19 +151,6 @@ private static async Task DownloadRotationsAsync(string relayFolder, bool mustDo
         if (hasDownload) LoadRotationsFromLocal(relayFolder);
     }
 
-    private static void PrintLoadedAssemblies(IEnumerable<string> assemblies)
-    {
-        foreach (var assembly in assemblies)
-        {
-            Service.ChatGui.Print("Loaded: " + assembly);
-        }
-    }
-
-    //private static async Task DownloadRotationsAsync(string relayFolder, bool mustDownload)
-    //{
-
-    //}
-
     private static async Task<bool> DownloadOneUrlAsync(string url, string relayFolder, HttpClient client, bool mustDownload)
     {
         try
@@ -211,6 +198,14 @@ private static async Task<bool> DownloadOneUrlAsync(string url, string relayFold
         return false;
     }
 
+    private static void PrintLoadedAssemblies(IEnumerable<string> assemblies)
+    {
+        foreach (var assembly in assemblies)
+        {
+            Service.ChatGui.Print("Loaded: " + assembly);
+        }
+    }
+
     private static Assembly LoadOne(string filePath)
     {
         try