fix: role action role check.

RotationSolver.Basic/Actions/ActionBasicInfo.cs

@@ -103,16 +103,21 @@ internal readonly bool BasicCheck(bool skipStatusProvideCheck, bool skipCombo, b
             if (player.HasStatus(true, _action.Setting.StatusProvide)) return false;
         }
 
-        if(_action.Action.ActionCategory.Row == 15)
+        if (_action.Action.ActionCategory.Row == 15)
         {
             if (CustomRotation.LimitBreakLevel <= 1) return false;
         }
 
-        if(!skipCombo && IsGeneralGCD)
+        if (!skipCombo && IsGeneralGCD)
         {
             if (!CheckForCombo()) return false;
         }
 
+        if (_action.Action.IsRoleAction)
+        {
+            if (!_action.Action.ClassJobCategory.Value?.IsJobInCategory(DataCenter.Job) ?? false) return false;
+        }
+
         //Need casting.
         if (CastTime > 0 && !player.HasStatus(true, 
             [
@@ -133,7 +138,7 @@ internal readonly bool BasicCheck(bool skipStatusProvideCheck, bool skipCombo, b
             && DataCenter.TimeSinceLastAction.TotalSeconds < 3) return false;
 
         if (!(_action.Setting.ActionCheck?.Invoke() ?? true)) return false;
-        if (!(_action.Setting.RotationCheck?.Invoke() ?? true)) return false;
+        if (!IBaseAction.ForceEnable && !(_action.Setting.RotationCheck?.Invoke() ?? true)) return false;
 
         return true;
     }

RotationSolver.Basic/Actions/BaseAction.cs

@@ -79,6 +79,7 @@ public bool CanUse(out IAction act, bool skipStatusProvideCheck = false, bool sk
         bool isEmpty = false, bool onLastAbility = false, bool ignoreClippingCheck = false, bool skipAoeCheck = false, byte gcdCountForAbility = 0)
     {
         act = this!;
+
         Setting.EndSpecial = IBaseAction.ShouldEndSpecial;
 
         if (IBaseAction.ActionPreview)

RotationSolver.Basic/DataCenter.cs

@@ -262,10 +262,9 @@ internal static SpecialCommandType SpecialType
 
     internal static float CombatTimeRaw { get; set; }
 
-    public static IEnumerable<BattleChara> PartyMembers { get; internal set; } = Array.Empty<PlayerCharacter>();
-    public static IEnumerable<BattleChara> AllianceMembers { get; internal set; } = Array.Empty<PlayerCharacter>();
-
-    public static IEnumerable<BattleChara> AllHostileTargets { get; internal set; } = Array.Empty<BattleChara>();
+    public static BattleChara[] PartyMembers { get; internal set; } = [];
+    public static BattleChara[] AllianceMembers { get; internal set; } = [];
+    public static BattleChara[] AllHostileTargets { get; internal set; } = [];
 
     public static BattleChara? InterruptTarget { get; internal set; }
 

RotationSolver/Localization/Localization.json

@@ -21,9 +21,6 @@
   "RotationSolver.Basic.Data.SpecialCommandType.Speed": "Open a window to speed up.",
   "RotationSolver.Basic.Data.TargetHostileType.TargetsHaveTarget": "Previously engaged targets (engages on countdown timer)",
   "RotationSolver.Data.UiString.ActionAttack": "Attack",
-  "RotationSolver.Data.UiString.ActionAbility": "Ability",
   "RotationSolver.Data.UiString.ActionFriendly": "Friendly",
-  "RotationSolver.Data.UiString.SpecialCommandType_Smart": "Auto Target ",
-  "RotationSolver.Data.UiString.SpecialCommandType_Off": "Off",
-  "RotationSolver.Data.UiString.SpecialCommandType_Cancel": "Cancel"
+  "RotationSolver.Data.UiString.ActionAbility": "Ability"
 }

RotationSolver/Updaters/MajorUpdater.cs

@@ -10,7 +10,6 @@
 using FFXIVClientStructs.FFXIV.Client.Game.Control;
 using FFXIVClientStructs.FFXIV.Client.Game.UI;
 using FFXIVClientStructs.FFXIV.Component.GUI;
-using RotationSolver.Basic.Configuration;
 using RotationSolver.Commands;
 using RotationSolver.Data;
 using RotationSolver.Localization;

RotationSolver/Updaters/TargetUpdater.cs

@@ -103,7 +103,7 @@ private unsafe static void UpdateHostileTargets(IEnumerable<BattleChara> allTarg
                 if (DownloadHelper.ContributorsHash.Contains(hash)) return false;
             }
             return true;
-        });
+        }).ToArray();
 
         var timesToKill = DataCenter.AllHostileTargets.Select(b => b.GetTimeToKill()).Where(v => !float.IsNaN(v));
         DataCenter.AverageTimeToKill = timesToKill.Any() ? timesToKill.Average() : 0;
@@ -204,8 +204,8 @@ private static bool IsHostileCastingBase(BattleChara h, Func<Action, bool> check
     private static uint _lastMp = 0;
     private unsafe static void UpdateFriends(IEnumerable<BattleChara> allTargets)
     {
-        DataCenter.AllianceMembers = allTargets.Where(ObjectHelper.IsAlliance);
-        DataCenter.PartyMembers = DataCenter.AllianceMembers.Where(ObjectHelper.IsParty);
+        DataCenter.AllianceMembers = allTargets.Where(ObjectHelper.IsAlliance).ToArray();
+        DataCenter.PartyMembers = DataCenter.AllianceMembers.Where(ObjectHelper.IsParty).ToArray();
 
         var mayPet = allTargets.OfType<BattleNpc>().Where(npc => npc.OwnerId == Player.Object.ObjectId);
         DataCenter.HasPet = mayPet.Any(npc => npc.BattleNpcKind == BattleNpcSubKind.Pet);