Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests: Add a test that worlds can create filler without generation steps #2073

Closed
wants to merge 3 commits into from

Conversation

alwaysintreble
Copy link
Collaborator

What is this fixing or adding?

Item Link filler replacement creates a new world and then creates filler with that world, if that new world can't actually create filler, generation will crash so this is a test for that.

How was this tested?

📄 ✍️

@Berserker66
Copy link
Member

Berserker66 commented Aug 1, 2023

This will need to check that the world even has items defined, so it doesn't fail on bk sudoku

@Berserker66
Copy link
Member

@espeon65536 for OoT and @lordlou for SMZ3
PoryGone said it will be fixed in the next SA2 update, which is unfortunate as I'd prefer it fixed in this AP update.

@kindasneaki
Copy link
Collaborator

I’m surprised RoR2 isn’t failing as it doesn’t have get_filler_item_name. Either way I’ll try to get it added as soon as I can

@el-u
Copy link
Collaborator

el-u commented Aug 1, 2023

I’m surprised RoR2 isn’t failing as it doesn’t have get_filler_item_name. Either way I’ll try to get it added as soon as I can

If you don't have get_filler_item_name you get to pass this particular test by for free because the default implementation can be called without generation steps (as long as the world defines at least one item).

But you'll fail #1172.

Co-authored-by: Fabian Dill <[email protected]>
@ThePhar ThePhar added is: enhancement Issues requesting new features or pull requests implementing new features. affects: core Issues/PRs that touch core and may need additional validation. labels Aug 16, 2023
@alwaysintreble
Copy link
Collaborator Author

Closing this as #2081 does the same thing but tests more things at the same time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
affects: core Issues/PRs that touch core and may need additional validation. is: enhancement Issues requesting new features or pull requests implementing new features.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants