Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: add instructions for installing Dark Souls III on linux #2799

Closed
wants to merge 1 commit into from

Conversation

Mojken
Copy link

@Mojken Mojken commented Feb 6, 2024

What is this fixing or adding?

Instructions for how to install the Dark Souls 3 mod on linux

How was this tested?

It was performed successfully (specifically, on nix-os)

And section Installation segment by platform
@ScipioWright ScipioWright added the is: documentation Improvements or additions to documentation. label Feb 7, 2024
@PoryGone PoryGone added waiting-on: world-maintainer Issue/PR is waiting for feedback or approval by the maintainer of a world. waiting-on: peer-review Issue/PR has not been reviewed by enough people yet. labels Feb 10, 2024
Copy link
Collaborator

@agilbert1412 agilbert1412 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instructions look pretty clear to me

@agilbert1412 agilbert1412 removed the waiting-on: peer-review Issue/PR has not been reviewed by enough people yet. label Feb 14, 2024
@Exempt-Medic Exempt-Medic requested a review from Marechal-L March 14, 2024 18:00
@nicholassaylor
Copy link
Contributor

This will be outdated with #3128 and should probably be closed since it is close to being merged

@Mojken
Copy link
Author

Mojken commented Aug 8, 2024

This will be outdated with #3128 and should probably be closed since it is close to being merged

Then, perhaps #3128 should provide installation instructions for linux from the get-go? If this had been merged back when, that PR probably would have already done so, rather than just removing it.

@nicholassaylor
Copy link
Contributor

#3817 Now covers linux installation under the 3.0.0 release

@Mojken
Copy link
Author

Mojken commented Sep 5, 2024

#3817 Now covers linux installation under the 3.0.0 release

That's great news!

@Mojken
Copy link
Author

Mojken commented Sep 5, 2024

Closing as it's outdated, replaced by #3817

@Mojken Mojken closed this Sep 5, 2024
@Mojken Mojken deleted the patch-1 branch September 5, 2024 20:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
is: documentation Improvements or additions to documentation. waiting-on: world-maintainer Issue/PR is waiting for feedback or approval by the maintainer of a world.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants