Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CommonClient: Port Casting Bug #2975

Merged
merged 3 commits into from
Mar 20, 2024
Merged

CommonClient: Port Casting Bug #2975

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a7a8fb3
make commonclient not seize up on an uncastable port
qwint Mar 16, 2024
36d3913
moved the port setting down to just reuse the later 'try' block becau…
qwint Mar 18, 2024
6695a65
adding comment to why the move happened
qwint Mar 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion CommonClient.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -643,13 +643,13 @@ async def server_loop(ctx: CommonContext, address: typing.Optional[str] = None)
ctx.username = server_url.username
if server_url.password:
ctx.password = server_url.password
port = server_url.port or 38281

def reconnect_hint() -> str:
return ", type /connect to reconnect" if ctx.server_address else ""

logger.info(f'Connecting to Archipelago server at {address}')
try:
port = server_url.port or 38281 # raises ValueError if invalid
socket = await websockets.connect(address, port=port, ping_timeout=None, ping_interval=None,
ssl=get_ssl_context() if address.startswith("wss://") else None)
if ctx.ui is not None:
Expand Down
Loading