Skip to content

Commit

Permalink
[pointer_interceptor_web] Skip broken semantics tests and do a manual…
Browse files Browse the repository at this point in the history
… roll (flutter#6342)

Skipping broken semantics tests. See: flutter/flutter#145238
  • Loading branch information
bparrishMines authored and arc-yong committed Jun 14, 2024
1 parent e0a957e commit ddf6a79
Show file tree
Hide file tree
Showing 2 changed files with 13 additions and 4 deletions.
2 changes: 1 addition & 1 deletion .ci/flutter_master.version
Original file line number Diff line number Diff line change
@@ -1 +1 @@
c01d7f06986146646fb26470453b9a6eda033872
71606af8d82e7a630aaff4d57cd5e984fcc3ae02
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,10 @@ void main() {

expect(element.tagName.toLowerCase(), 'flt-semantics');
expect(element.getAttribute('aria-label'), 'Works As Expected');
});
},
// TODO(bparrishMines): The semantics label is returning null.
// See https://github.com/flutter/flutter/issues/145238
skip: true);

testWidgets(
'finds semantics of wrapped widgets with intercepting set to false',
Expand All @@ -88,7 +91,10 @@ void main() {
expect(element.tagName.toLowerCase(), 'flt-semantics');
expect(element.getAttribute('aria-label'),
'Never calls onPressed transparent');
});
},
// TODO(bparrishMines): The semantics label is returning null.
// See https://github.com/flutter/flutter/issues/145238
skip: true);

testWidgets('finds semantics of unwrapped elements',
(WidgetTester tester) async {
Expand All @@ -99,7 +105,10 @@ void main() {

expect(element.tagName.toLowerCase(), 'flt-semantics');
expect(element.getAttribute('aria-label'), 'Never calls onPressed');
});
},
// TODO(bparrishMines): The semantics label is returning null.
// See https://github.com/flutter/flutter/issues/145238
skip: true);

// Notice that, when hit-testing the background platform view, instead of
// finding a semantics node, the platform view itself is found. This is
Expand Down

0 comments on commit ddf6a79

Please sign in to comment.