Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add secondary button outline #113

Merged
merged 2 commits into from
Apr 2, 2024
Merged

Conversation

shahin-hq
Copy link
Contributor

@shahin-hq shahin-hq commented Mar 29, 2024

Summary

Closes: https://app.clickup.com/t/86dt3c99x

  • adds a border for the cancel button
  • adds an outline for the focus state for all buttons
  • ensures the fee switch input has the same focus state with buttons
  • adds a translation string for the Fee label

Checklist

  • I checked the basic interactions between demo and extension, making sure wallet selection works
  • I checked my UI changes against the design and there are no notable differences, including responsiveness
  • I checked my (code) changes for obvious issues, debug statements and commented code
  • I opened a corresponding card on Clickup for any remaining TODOs in my code
  • I added a short description on how to test this PR (if necessary)
  • Ready to be merged

Copy link

vercel bot commented Mar 29, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
arkconnect-demo ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 29, 2024 0:26am

Copy link
Contributor

@ItsANameToo ItsANameToo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the cancel button is missing a hover state in light mode

@ItsANameToo ItsANameToo changed the title fix: add button outline fix: add secondary button outline Apr 2, 2024
@ItsANameToo ItsANameToo merged commit 5c44e33 into develop Apr 2, 2024
2 checks passed
@ItsANameToo ItsANameToo deleted the fix/button-outline branch April 2, 2024 09:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants