fix: refresh balance on address change #84
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
shahin-hq
force-pushed
the
fix/refresh-balance-on-address-change
branch
from
34fdc14 to
3f8b7d3
Compare
shahin-hq
force-pushed
the
fix/refresh-balance-on-address-change
branch
from
3f8b7d3 to
5df544f
Compare
shahin-hq
force-pushed
the
fix/refresh-balance-on-address-change
branch
from
28db195 to
7904c13
Compare
…hange' into fix/refresh-balance-on-address-change # Conflicts: # src/app/hooks/useWalletBalance.ts
shahin-hq
force-pushed
the
fix/refresh-balance-on-address-change
branch
from
b4c6d1a to
4e4d1e3
Compare
goga-m
approved these changes
Mar 7, 2024
patricio0312rev
approved these changes
Mar 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: https://app.clickup.com/t/86drpzvd8
Problem:
Every time wallet changes
useWalletBalanceshould trigger and recalculate balance in USD, the problem is if wallets get changed multiple times in a fraction of minute we may hit Coingecko rate limits.Solution:
The root of problem is having a
Coingeckoinstance inWalletobject, this basically causes problem because of how things work:useWalletBalanceget called with new wallet which creates aWalletinstance with the new walletWalletinstance = creating a newCoingeckowhich means losing the cached valuesInstead of that we could have a
Coingeckoinstance managed byuseQueryand data could be passed to theWalletwhen it is required to use. I could pass it through theconstructor, however, this would be aggressive as there might be cases we might needWalletinstance without using any balance/rate related logic. That is why decided to pass it as a function argument.new_recording_-_2_28_2024._5_42_18_pm.Original.mp4