Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: transaction repository #1183

Merged
merged 6 commits into from
Feb 6, 2025

Conversation

alexbarnsley
Copy link
Member

@alexbarnsley alexbarnsley commented Feb 5, 2025

Summary

https://app.clickup.com/t/86dvd9jec

Since asset is no longer available, I've adjusted the queries to parse transaction data. An alternative to this approach would be to cache multipayment recipients (potentially using an adjusted scope), but this could cache a lot of data in the future.

Checklist

  • I checked my UI changes against the design and there are no notable differences
  • I checked my UI changes for any responsiveness issues
  • I checked my UI changes in light AND dark mode
  • I checked my (code) changes for obvious issues, debug statements and commented code
  • I opened a corresponding card on Clickup for any remaining TODOs in my code
  • I added a short description on how to test this PR (if necessary)
  • Documentation (if necessary)
  • Tests (if necessary)
  • Ready to be merged

@ItsANameToo ItsANameToo merged commit 1378570 into mainsail-develop Feb 6, 2025
8 of 9 checks passed
@ItsANameToo ItsANameToo deleted the refactor/transaction-repository branch February 6, 2025 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants