Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add mainsail networks #418

Merged
merged 11 commits into from
Apr 3, 2024
Merged

Conversation

ItsANameToo
Copy link
Contributor

@ItsANameToo ItsANameToo commented Apr 2, 2024

Summary

Important note: use a proper mnemonic when testing as only that one is supported until we refactor the Mainsail implementation to use the Signatory object.

app.clickup.com/t/86drv2263, but also

Requires ArdentHQ/platform-sdk#49

Remaining:

  • make transfer work

Moving https://app.clickup.com/t/86dt5kmex to a separate PR as this only happens when making adjustments locally and rerunning pnpm dev

Checklist

  • My changes look good in both light AND dark mode
  • The change is not hardcoded to a single network, but has multi-asset in mind
  • I checked my changes for obvious issues, debug statements and commented code
  • Documentation (if necessary)
  • Tests (if necessary)
  • Ready to be merged

Copy link

vercel bot commented Apr 2, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
arkvault ❌ Failed (Inspect) Apr 3, 2024 1:44pm

@ItsANameToo ItsANameToo mentioned this pull request Apr 2, 2024
6 tasks
@ItsANameToo ItsANameToo marked this pull request as ready for review April 3, 2024 08:04
@ItsANameToo ItsANameToo changed the base branch from develop to feat/mainsail April 3, 2024 08:05
@ItsANameToo ItsANameToo marked this pull request as draft April 3, 2024 08:23
@ItsANameToo ItsANameToo marked this pull request as ready for review April 3, 2024 13:49
@ItsANameToo ItsANameToo merged commit d507f4a into feat/mainsail Apr 3, 2024
18 of 53 checks passed
@ItsANameToo ItsANameToo deleted the feat/add-mainsail-network branch April 3, 2024 14:12
@ItsANameToo ItsANameToo mentioned this pull request Apr 3, 2024
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants