refactor: delegate table username/rank adjustments #427
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alfonsobries
requested review from
ItsANameToo,
samharperpittam,
goga-m,
boldninja and
alexbarnsley
as code owners
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
ItsANameToo
approved these changes
Apr 5, 2024
|
works apart from the delegate order that needs fixing, but that's on the API side |
ItsANameToo
reviewed
Apr 5, 2024
Comment on lines
+216
to
+220
| {delegate.username() ? ( | ||
| <div className="overflow-hidden text-ellipsis">{delegate.username()}</div> | ||
| ): ( | ||
| <TruncateMiddleDynamic value={delegate.address()} availableWidth={width} /> | ||
| )} |
There was a problem hiding this comment.
will leave this for now, but later on we need a generic handler as it will apply to regular wallets and other parts of the UI as well
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Related: https://app.clickup.com/t/86dt5qa1x
Depends on: https://github.com/ArdentHQ/platform-sdk/pull/58/files
Checklist