refactor: hide mainsail not supported transactions #439
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alfonsobries
requested review from
ItsANameToo,
samharperpittam,
goga-m,
boldninja and
alexbarnsley
as code owners
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
ItsANameToo
requested changes
Apr 10, 2024
| @@ -85,10 +85,14 @@ export const useTransactionTypes = ({ wallets = [] }: TransactionTypeProperties | |||
| }, | |||
| }; | |||
|
|
|||
| const mainsailUnsupportedTypes = new Set(["htlcClaim", "htlcLock", "htlcRefund", "ipfs", "secondSignature", "magistrate"]); | |||
There was a problem hiding this comment.
this shouldn't be necessary. The wallet.transactionTypes() should instead only list supported types. For example for Mainsail it currently lists these when you log it:
["delegateRegistration","usernameRegistration","usernameResignation","delegateResignation","ipfs","multiPayment","multiSignature","secondSignature","transfer","vote"]
This still includes IPFS and secondSignature, but that means you need to adjust this on the PSDK side to not return unsupported transaction types
|
closing in favour of ArdentHQ/platform-sdk#65 as that will hide these values in the UI automatically |
ItsANameToo
deleted the
refactor/hide-mainsail-not-supported-transactions
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Closes https://app.clickup.com/t/86dt7cxy1
Checklist