Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: ensure wallets are synced on transaction fetching #894

Merged
merged 3 commits into from
Jan 17, 2025
Merged

fix: ensure wallets are synced on transaction fetching #894

merged 3 commits into from
Jan 17, 2025
+17 −2

Conversation

goga-m
Copy link
Contributor

@goga-m goga-m commented Jan 16, 2025

Summary

Closes https://app.clickup.com/t/86dvpfyyt

Checklist

  • My changes look good in both light AND dark mode
  • The change is not hardcoded to a single network, but has multi-asset in mind
  • I checked my changes for obvious issues, debug statements and commented code
  • Documentation (if necessary)
  • Tests (if necessary)
  • Ready to be merged

@vercel Vercel
Copy link

vercel bot commented Jan 16, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
arkvault ✅ Ready (Inspect) Visit Preview Jan 17, 2025 9:48am

@goga-m goga-m changed the title fix: ensure wallets are sync on transaction table fetching fix: ensure wallets are sync on transaction fetching Jan 16, 2025
@goga-m goga-m changed the title fix: ensure wallets are sync on transaction fetching fix: ensure wallets are synced on transaction fetching Jan 16, 2025
@goga-m
Copy link
Contributor Author

goga-m commented Jan 16, 2025

The error in wallet domain should be fixed in #896

@ItsANameToo ItsANameToo merged commit 89275b3 into feat/evm Jan 17, 2025
18 checks passed
@ItsANameToo ItsANameToo deleted the fix/sync-wallets-transactions-table branch January 17, 2025 09:54
@ItsANameToo ItsANameToo added this to the mainsail-evm milestone Jan 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ItsANameToo ItsANameToo ItsANameToo approved these changes

@samharperpittam samharperpittam Awaiting requested review from samharperpittam samharperpittam is a code owner

@boldninja boldninja Awaiting requested review from boldninja boldninja is a code owner

@alexbarnsley alexbarnsley Awaiting requested review from alexbarnsley alexbarnsley is a code owner

Assignees
No one assigned
Labels
bugfix
Projects
None yet
Milestone
mainsail-evm
Development

Successfully merging this pull request may close these issues.
2 participants
@goga-m @ItsANameToo