Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: correct outgoing & incoming transactions for multiple wallets #922

Merged
merged 8 commits into from
Jan 30, 2025
Merged

fix: correct outgoing & incoming transactions for multiple wallets #922

merged 8 commits into from
Jan 30, 2025

Conversation

goga-m
Copy link
Contributor

@goga-m goga-m commented Jan 29, 2025 •
edited
Loading

Summary

Depends on ArdentHQ/platform-sdk#155
Closes https://app.clickup.com/t/86dvuzxcu

Checklist

  • My changes look good in both light AND dark mode
  • The change is not hardcoded to a single network, but has multi-asset in mind
  • I checked my changes for obvious issues, debug statements and commented code
  • Documentation (if necessary)
  • Tests (if necessary)
  • Ready to be merged

@vercel Vercel
Copy link

vercel bot commented Jan 29, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
arkvault ✅ Ready (Inspect) Visit Preview Jan 30, 2025 0:33am

@goga-m goga-m marked this pull request as ready for review January 29, 2025 14:41
@goga-m goga-m marked this pull request as draft January 29, 2025 16:32
@goga-m goga-m marked this pull request as ready for review January 30, 2025 11:00
@goga-m
Copy link
Contributor Author

goga-m commented Jan 30, 2025 •
edited
Loading

@ItsANameToo @samharperpittam the labels are misleading in the transaction rows, which I think it should be handled in #924 and we could start testing this one to make sure that the correct txs appear for multiple wallets.

@ItsANameToo ItsANameToo merged commit 0b25f5b into feat/evm Jan 30, 2025
17 checks passed
@ItsANameToo ItsANameToo deleted the fix/multiple-wallet-transactions branch January 30, 2025 14:04
@ItsANameToo ItsANameToo added this to the mainsail-evm milestone Jan 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samharperpittam samharperpittam samharperpittam approved these changes

@ItsANameToo ItsANameToo ItsANameToo approved these changes

@boldninja boldninja Awaiting requested review from boldninja boldninja is a code owner

@alexbarnsley alexbarnsley Awaiting requested review from alexbarnsley alexbarnsley is a code owner

Assignees
No one assigned
Labels
bugfix
Projects
None yet
Milestone
mainsail-evm
Development

Successfully merging this pull request may close these issues.
3 participants
@goga-m @ItsANameToo @samharperpittam