refactor: update ark decimals to 18 and new helpers #114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
patricio0312rev
commented
Nov 18, 2024
packages/helpers/source/index.ts
Outdated
| @@ -13,10 +13,10 @@ export * from "./cast-array.js"; | |||
| export * from "./censor.js"; | |||
| export * from "./chars.js"; | |||
| export * from "./chunk.js"; | |||
| export * from "./clone.js"; | |||
There was a problem hiding this comment.
The changes here were made by my autoformatter on save 😅
There was a problem hiding this comment.
aren't these obsolete now you don't include it anymore in the helper package? 🤔
ItsANameToo
requested changes
Nov 18, 2024
….com/ArdentHQ/platform-sdk into refactor/update-decimals-and-helpers
….com/ArdentHQ/platform-sdk into refactor/update-decimals-and-helpers
patricio0312rev
commented
Nov 18, 2024
| @@ -0,0 +1,16 @@ | |||
| import { formatUnits } from "./format-units"; | |||
There was a problem hiding this comment.
I see the tests aren't configured yet for mainsail. Should I remove these files until then? 🤔
There was a problem hiding this comment.
issue is that the mainsail package is a copy of ark and not everything may work. I'll add a card though to enable tests based on the areas that are working so those run at least
ItsANameToo
approved these changes
Nov 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[psdk] handle decimals (18) & [psdk] add formatter methods
Changes
1e8to1e18.formatUnitsandparseUnitsmethods based on the ones created in PHP.