Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: remove deprecated ledger u2f transport #18

Merged
merged 2 commits into from
Mar 15, 2024

Conversation

goga-m
Copy link
Contributor

@goga-m goga-m commented Feb 22, 2023

@ledgerhq/hw-transport-u2f is officially deprecated and webusb or webhid are the recommended web-based transports for browsers that support these APIs (currently chromium based browsers).

See more: https://www.npmjs.com/package/@ledgerhq/hw-transport-u2f

@goga-m goga-m changed the base branch from develop to main February 22, 2023 12:18
@goga-m goga-m force-pushed the refactor/drop-ledger-u2f branch from d0625db to 831dfe8 Compare February 22, 2023 12:19
@goga-m goga-m changed the base branch from main to develop February 22, 2023 12:19
@ItsANameToo ItsANameToo changed the base branch from bearmint to develop November 29, 2023 09:58
@ItsANameToo
Copy link
Contributor

can you rebase this against current main branch @goga-m ? then we can include it with the other changes related to mainsail

@goga-m goga-m force-pushed the refactor/drop-ledger-u2f branch from feabcc7 to d160fde Compare March 14, 2024 16:28
@goga-m goga-m changed the base branch from develop to main March 14, 2024 16:29
@goga-m goga-m force-pushed the refactor/drop-ledger-u2f branch from d160fde to e6add60 Compare March 14, 2024 16:30
@goga-m goga-m force-pushed the refactor/drop-ledger-u2f branch from e6add60 to 03f4bf6 Compare March 14, 2024 16:41
@goga-m goga-m marked this pull request as draft March 15, 2024 08:30
@goga-m goga-m marked this pull request as ready for review March 15, 2024 08:55
@goga-m
Copy link
Contributor Author

goga-m commented Mar 15, 2024

It should be ok now @ItsANameToo

@ItsANameToo ItsANameToo merged commit aa4fb5e into main Mar 15, 2024
4 checks passed
@ItsANameToo ItsANameToo deleted the refactor/drop-ledger-u2f branch March 15, 2024 09:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants