Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: use correct path for transaction username #60

Merged
merged 2 commits into from
Apr 8, 2024
Merged

fix: use correct path for transaction username #60

merged 2 commits into from
Apr 8, 2024

Conversation

goga-m
Copy link
Contributor

@goga-m goga-m commented Apr 5, 2024 •
edited
Loading

@github-actions github-actions bot added the bugfix label Apr 5, 2024
ItsANameToo
ItsANameToo reviewed Apr 5, 2024
View reviewed changes
packages/mainsail/source/confirmed-transaction.dto.ts Outdated
@@ -131,7 +131,7 @@ export class ConfirmedTransactionData extends DTO.AbstractConfirmedTransactionDa

// Delegate Registration
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this comment need updating as it's no longer related to a delegate registration

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ItsANameToo updated.

@goga-m goga-m mentioned this pull request Apr 5, 2024
Merged
6 tasks
@ItsANameToo ItsANameToo merged commit 9ba1162 into feat/mainsail Apr 8, 2024
2 checks passed
@ItsANameToo ItsANameToo deleted the fix/username-confirmed-dto branch April 8, 2024 08:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ItsANameToo ItsANameToo ItsANameToo approved these changes

Assignees
No one assigned
Labels
bugfix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@goga-m @ItsANameToo