Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not broadcast empty messages #103

Merged

Conversation

BluemarkInnovations
Copy link
Contributor

The BT5. WLAN NaN and WLAN broadcast function use the odid_message_build_pack function of the opendrone ID lib to encode data. That function uses the "valid" vars of each packet (basicID, location, system etc) to determine if it needs to be encoded. The BT4 transmission uses a slightly different approach, not using these "valid" vars

In this PR:

  • use the "valid" vars for BT4 transmission too (to have similar behavior for all transmission protocols)
  • only set SelfID and operatorID packets to valid if data is entered.

Copy link
Contributor

@tridge tridge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've dropped the valid zeroing change, better to have #104

@tridge tridge force-pushed the do_not_broadcast_empty_messages branch from 3451aa7 to 61d3c3f Compare March 5, 2023 02:01
@BluemarkInnovations
Copy link
Contributor Author

I've dropped the valid zeroing change, better to have #104

Agree.

@tridge tridge force-pushed the do_not_broadcast_empty_messages branch from 61d3c3f to 84d8bbf Compare March 24, 2023 00:32
@tridge tridge merged commit d6d3808 into ArduPilot:master Mar 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants