Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dual ID implementation #73

Merged
merged 1 commit into from
Oct 14, 2022
Merged

Conversation

BluemarkInnovations
Copy link
Contributor

@BluemarkInnovations BluemarkInnovations commented Sep 26, 2022

  • implemented the back-end for PR web: Display two types of BASIC ID messages #66 / @muramura
  • the implementation decodes basic ID messages from MAVLink or DroneCAN. In case, there are more than 2 basic IDs, it will overwrite always the second basic ID and keeps the first basic ID unchanged. E.g. if 4 basic IDs are transported via MAVLink/ DroneCAN, the first basic ID will be the first received basic ID message. The second basic ID will be continuously overwritten by the 2nd, 3rd and 4th basic ID messages.
  • not tested yet, but compiles without errors

@BluemarkInnovations BluemarkInnovations changed the title implemented the backend of the dual ID broadcast feature dual ID implementation Sep 26, 2022
@BluemarkInnovations BluemarkInnovations marked this pull request as draft September 27, 2022 10:56
@BluemarkInnovations
Copy link
Contributor Author

This is the final PR for this functionality.

The implementation has changed a bit.

  • The first basic ID message is always based on the one set in the parameters.
  • The second basic ID message is received from MAVLink or DroneCAN. If none is received, the second basic ID from the parameters is used.
  • This setup makes the implementation more straight forward and prevents to override the basic ID, set by the parameters (tamper proof).
  • The second basic ID can be set by the MAVLink or DroneCAN and is useful if one needs to set a temporarily ID.
  • tested via mavproxy and setting UAS_ID field

@BluemarkInnovations
Copy link
Contributor Author

I struggled to rebase this PR to the current version of the code. Older PRs are still showing up. @tridge let me know how to solve.

@tridge tridge force-pushed the dual_id branch 2 times, most recently from 0dfd5bb to 59a9799 Compare October 14, 2022 09:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants