Provide a pop up if the OTA upgrade fails #91
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tridge
force-pushed
the
failed_firmware_upgrade
branch
from
bc8f5e1 to
d6b9012
Compare
|
i've been testing this by trying to load a fw with the wrong board ID and it still gives me success display, but doesn't update the fw |
|
improved PR, solved a bug in the check_OTA_partition function. |
tridge
force-pushed
the
failed_firmware_upgrade
branch
from
e69e3d4 to
082cc30
Compare
|
@BluemarkInnovations thanks, I've fixed the PR to squash the commits, and have gone back to using a reference (no need to use a pointer for the board_id) |
Thanks, I wasn't familiar with references in C. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR, a pop up is shown if the OTA upgrade via the web interface fails.
For instance if the wrong file is uploaded.